Skip to content

Fix flaky IMDS client test #3912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 18, 2023
Merged

Fix flaky IMDS client test #3912

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a893f54
Fix flaky IMDS client test
dagnir Apr 14, 2023
0b98c09
Merge branch 'master' into dongie/fix-imds-client-test
dagnir Apr 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 41 additions & 7 deletions core/imds/src/test/java/software/amazon/awssdk/imds/internal/CachedTokenClientTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,16 +28,32 @@
import static com.github.tomakehurst.wiremock.stubbing.Scenario.STARTED;
import static org.assertj.core.api.Assertions.assertThat;
import static org.assertj.core.api.Assertions.assertThatThrownBy;
import static org.mockito.ArgumentMatchers.any;
import static org.mockito.Mockito.mock;
import static org.mockito.Mockito.when;
import static software.amazon.awssdk.imds.TestConstants.EC2_METADATA_TOKEN_TTL_HEADER;

import com.github.tomakehurst.wiremock.junit5.WireMockRuntimeInfo;
import com.github.tomakehurst.wiremock.junit5.WireMockTest;
import java.io.ByteArrayInputStream;
import java.io.IOException;
import java.net.URI;
import java.nio.charset.StandardCharsets;
import java.time.Duration;
import org.junit.jupiter.api.AfterEach;
import org.junit.jupiter.api.BeforeEach;
import org.junit.jupiter.api.Test;
import org.mockito.ArgumentCaptor;
import org.mockito.Mockito;
import software.amazon.awssdk.core.exception.SdkClientException;
import software.amazon.awssdk.http.AbortableInputStream;
import software.amazon.awssdk.http.ExecutableHttpRequest;
import software.amazon.awssdk.http.HttpExecuteRequest;
import software.amazon.awssdk.http.HttpExecuteResponse;
import software.amazon.awssdk.http.SdkHttpClient;
import software.amazon.awssdk.http.SdkHttpFullResponse;
import software.amazon.awssdk.http.SdkHttpRequest;
import software.amazon.awssdk.http.SdkHttpResponse;
import software.amazon.awssdk.imds.Ec2MetadataClient;
import software.amazon.awssdk.imds.Ec2MetadataResponse;

Expand All @@ -58,13 +74,31 @@ void tearDown(WireMockRuntimeInfo wmRuntimeInfo) {
}

@Test
void get_tokenFailsError4xx_shouldNotRetry() {
stubFor(put(urlPathEqualTo("/latest/api/token")).willReturn(aResponse().withStatus(400).withBody("ERROR 400")));
stubFor(get(urlPathEqualTo("/latest/meta-data/ami-id")).willReturn(aResponse().withBody("{}")));

assertThatThrownBy(() -> clientBuilder.build().get("/latest/meta-data/ami-id")).isInstanceOf(SdkClientException.class);
verify(exactly(1), putRequestedFor(urlPathEqualTo("/latest/api/token"))
.withHeader("x-aws-ec2-metadata-token-ttl-seconds", equalTo("21600")));
void get_tokenFailsError4xx_shouldNotRetry() throws IOException {
SdkHttpClient mockClient = mock(SdkHttpClient.class);
ExecutableHttpRequest mockRequest = mock(ExecutableHttpRequest.class);
when(mockClient.prepareRequest(any(HttpExecuteRequest.class))).thenReturn(mockRequest);

AbortableInputStream content =
AbortableInputStream.create(new ByteArrayInputStream("ERROR 400".getBytes(StandardCharsets.UTF_8)));
SdkHttpResponse httpResponse = SdkHttpFullResponse.builder()
.statusCode(400)
.build();
HttpExecuteResponse executeResponse = HttpExecuteResponse.builder()
.response(httpResponse)
.responseBody(content)
.build();
when(mockRequest.call()).thenReturn(executeResponse);

Ec2MetadataClient imdsClient = Ec2MetadataClient.builder().httpClient(mockClient).build();

assertThatThrownBy(() ->imdsClient.get("/latest/meta-data/ami-id")).isInstanceOf(SdkClientException.class);

ArgumentCaptor<HttpExecuteRequest> requestCaptor = ArgumentCaptor.forClass(HttpExecuteRequest.class);
Mockito.verify(mockClient).prepareRequest(requestCaptor.capture());
SdkHttpRequest httpRequest = requestCaptor.getValue().httpRequest();
assertThat(httpRequest.encodedPath()).isEqualTo("/latest/api/token");
assertThat(httpRequest.firstMatchingHeader("x-aws-ec2-metadata-token-ttl-seconds").get()).isEqualTo("21600");
}

@Test
Expand Down