Skip to content

Add interface stubs for new signer implementations #3997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

haydenbaker
Copy link
Contributor

Motivation and Context

Modifications

This commit adds the new Signer interface stubs and poms to respective modules

Testing

$ ./mvnw -pl :http-auth,:http-auth-aws,:http-auth-aws-crt,:http-auth-event-stream clean install -am

  • Made sure there were no build errors

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed
  • I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

@haydenbaker haydenbaker requested a review from gosar May 11, 2023 20:05
@haydenbaker haydenbaker requested a review from a team as a code owner May 11, 2023 20:05
Copy link
Contributor

@gosar gosar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll need to add javadocs to the interfaces, but I'm ok to merge these stubs sooner to unblock auth scheme resolution changes I'm working on, and add javadocs when you work on the implementations.

<artifactId>http-auth</artifactId>
<name>AWS Java SDK :: HTTP Auth</name>
<description>
The AWS SDK for Java - HTTP Auth module contains interfaces and implementations for http authentication
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: maybe this should use the term "generic", i.e., for generic HTTP services. Also, in these sentences when using http, maybe it should be HTTP.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I figured we could add the doc-comments in the follow-up PR for implementation

@haydenbaker haydenbaker requested a review from zoewangg May 11, 2023 21:39
@gosar gosar mentioned this pull request May 11, 2023
12 tasks
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug C 3 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 75 Code Smells

49.8% 49.8% Coverage
3.2% 3.2% Duplication

@haydenbaker haydenbaker merged commit 0d7b693 into feature/master/sra-identity-auth May 12, 2023
@haydenbaker haydenbaker deleted the haydenbaker/sra-ia-signer-interfaces branch May 12, 2023 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants