s3-becnhmarks - Change NoopTransformer type-param to Object #5112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Transfer Manager Benchmarks that download to memory with java-based client would hang because the result of the future in
NoOpResponseTransformeris set to null. Eventually, this null reaches the CompletedFileDownload constructor which assert that it must not be null. It is called from the generic transfer manager code pathMotivation and Context
During java-based performance benchmarks, I notice some of the benchmarks would hang and not complete. This is the root cause of it.
We also need to spend a little bit more time investigating how it impacts the java-based client, and if this is a bug that must be fixed in there too.
Modifications
We now complete the future with a new Object instance.
Testing
Ran the benchmarks with the change, they completed successfully