Skip to content

s3-becnhmarks - Change NoopTransformer type-param to Object #5112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 17, 2024
Merged

s3-becnhmarks - Change NoopTransformer type-param to Object #5112

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions ...benchmarks/src/main/java/software/amazon/awssdk/s3benchmarks/NoOpResponseTransformer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,11 +25,11 @@
/**
* A no-op {@link AsyncResponseTransformer}
*/
public class NoOpResponseTransformer<T> implements AsyncResponseTransformer<T, Void> {
private CompletableFuture<Void> future;
public class NoOpResponseTransformer<T> implements AsyncResponseTransformer<T, Object> {
private CompletableFuture<Object> future;

@Override
public CompletableFuture<Void> prepare() {
public CompletableFuture<Object> prepare() {
future = new CompletableFuture<>();
return future;
}
Expand All @@ -50,10 +50,10 @@ public void exceptionOccurred(Throwable error) {
}

static class NoOpSubscriber implements Subscriber<ByteBuffer> {
private final CompletableFuture<Void> future;
private final CompletableFuture<Object> future;
private Subscription subscription;

NoOpSubscriber(CompletableFuture<Void> future) {
NoOpSubscriber(CompletableFuture<Object> future) {
this.future = future;
}

Expand All @@ -75,7 +75,7 @@ public void onError(Throwable throwable) {

@Override
public void onComplete() {
future.complete(null);
future.complete(new Object());
}
}

Expand Down
2 changes: 1 addition & 1 deletion ...s/src/main/java/software/amazon/awssdk/s3benchmarks/TransferManagerDownloadBenchmark.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ private void downloadOnceToFile(List<Double> latencies) throws Exception {

private void downloadOnceToMemory(List<Double> latencies) throws Exception {
long start = System.currentTimeMillis();
AsyncResponseTransformer<GetObjectResponse, Void> responseTransformer = new NoOpResponseTransformer<>();
AsyncResponseTransformer<GetObjectResponse, Object> responseTransformer = new NoOpResponseTransformer<>();
transferManager.download(DownloadRequest.builder()
.getObjectRequest(req -> req.bucket(bucket).key(key))
.responseTransformer(responseTransformer)
Expand Down