Skip to content

S3 PutObject String overload #5429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

davidh44
Copy link
Contributor

Motivation and Context

Transforming putObject overload for String payload:
putObject(String bucketName, String key, String content)

Testing

Added unit and end-to-end tests

@davidh44 davidh44 requested a review from a team as a code owner July 25, 2024 23:59
@davidh44 davidh44 changed the base branch from feature/master/migration-tool to feature/master/migration-tool-updates July 26, 2024 18:03
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
8.2% Coverage on New Code (required ≥ 80%)
D Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@davidh44 davidh44 merged commit 672d973 into feature/master/migration-tool-updates Jul 29, 2024
16 of 17 checks passed
@davidh44 davidh44 deleted the hdavidh/s3-put-overloads branch July 29, 2024 18:10
@davidh44 davidh44 mentioned this pull request Aug 9, 2024
12 tasks
davidh44 added a commit that referenced this pull request Aug 9, 2024
* S3 PutObject String overload

* Add comment
@davidh44 davidh44 mentioned this pull request Aug 9, 2024
12 tasks
davidh44 added a commit that referenced this pull request Aug 9, 2024
* S3 PutObject String overload (#5429)

* S3 PutObject String overload

* Add comment

* S3 CreateBucket DeleteBucket single arg overloads (#5438)

* S3 CreateBucket DeleteBucket single arg overload

* Address comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants