S3 CreateBucket DeleteBucket single arg overloads #5438
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
zoewangg
approved these changes
Jul 29, 2024
|
|
||
| @Override | ||
| public String getDescription() { | ||
| return "S3NonStreamingRequestToV2."; |
There was a problem hiding this comment.
Nit: can we have a more descriptive description? :) Same for display name
Comment on lines
68
to
73
| if (CREATE_BUCKET.matches(method, false)) { | ||
| method = transformBucketNameArgOverload(method, V1_CREATE_BUCKET_REQUEST); | ||
| } | ||
| if (DELETE_BUCKET.matches(method, false)) { | ||
| method = transformBucketNameArgOverload(method, V1_DELETE_BUCKET_REQUEST); | ||
| } |
There was a problem hiding this comment.
nit: suggest doing else if or returning immediately
davidh44
merged commit 1eaf187
into
feature/master/migration-tool-updates
7 of 8 checks passed
davidh44
added a commit
that referenced
this pull request
Aug 9, 2024
* S3 CreateBucket DeleteBucket single arg overload * Address comments
davidh44
added a commit
that referenced
this pull request
Aug 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Transforming
createBucketanddeleteBucketoverloads withbucketString argumentTesting
Added unit and end-to-end tests