aws · zoewangg · Aug 8, 2018 · Aug 8, 2018 · zoewangg · Aug 8, 2018
@@ -5,7 +5,7 @@
         {
             "category": "AWS SDK for Java v2",
             "type": "feature",
-            "description": "Substantial improvments to start up time and cold start latencies"
+            "description": "Substantial improvements to start up time and cold start latencies"
         },
         {
             "category": "AWS SDK for Java v2",

@@ -35,7 +35,7 @@
         {
             "category": "AWS SDK for Java v2",
             "type": "bugfix",
-            "description": "Many improvments and fixes to the Netty NIO based transport."
+            "description": "Many improvements and fixes to the Netty NIO based transport."
         },
         {
             "category": "AWS SDK for Java v2",

@@ -306,7 +306,7 @@
 
   - ### Bugfixes
     - Fixed a bug in default credential provider chain where it would erroneously abort at the ProfileCredentialsProvider. See [Issue #135](https://github.com/aws/aws-sdk-java-v2/issues/135)
-    - Many improvments and fixes to the Netty NIO based transport.
+    - Many improvements and fixes to the Netty NIO based transport.
     - Several fixes around S3's endpoint resolution, particularly with advanced options like path style addressing and accelerate mode. See [Issue #130](https://github.com/aws/aws-sdk-java-v2/issues/130)
     - Several fixes around serialization and deserialization of immutable objects. See [Issue #122](https://github.com/aws/aws-sdk-java-v2/issues/122)
     - Type parameters are now correctly included for [StreamingResponseHandler](https://github.com/aws/aws-sdk-java-v2/blob/master/core/src/main/java/software/amazon/awssdk/sync/StreamingResponseHandler.java) on the client interface.
@@ -321,7 +321,7 @@
   - ### Features
     - New pluggable HTTP implementation built on top of Java's HttpUrlConnection. Good choice for simple applications with low throughput requirements. Better cold start latency than the default Apache implementation.
     - Simple convenience methods have been added for operations that require no input parameters.
-    - Substantial improvments to start up time and cold start latencies
+    - Substantial improvements to start up time and cold start latencies
     - The Netty NIO HTTP client now uses a shared event loop group for better resource management. More options for customizing the event loop group are now available.
     - Using java.time instead of the legacy java.util.Date in generated model classes.
     - Various improvements to the immutability of model POJOs. ByteBuffers are now copied and collections are returned as unmodifiable.

@@ -208,7 +208,7 @@ public DocumentationBuilder see(String seeLink, Object... formatArgs) {
     }
 
     /**
-     * Builds the Javadoc string with the current configuraton.
+     * Builds the Javadoc string with the current configuration.
      *
      * @return Formatted Javadoc string.
      */

@@ -134,7 +134,7 @@ private URI createGenericContainerUrl() {
             if (!ALLOWED_HOSTS.contains(uri.getHost())) {
 
                 throw SdkClientException.builder()
-                                        .message(String.format("The full URI (%s) contained withing environment " +
+                                        .message(String.format("The full URI (%s) contained within environment " +
                                                  "variable %s has an invalid host. Host can only be one of [%s].",
                                                  uri,
                                                  SdkSystemSetting.AWS_CONTAINER_CREDENTIALS_FULL_URI
@@ -178,4 +178,4 @@ public ContainerCredentialsProvider build() {
             return new ContainerCredentialsProvider(this);
         }
     }
-}
+}
@@ -148,7 +148,7 @@ public int getCurrentDepth() {
      * document being parsed.
      *
      * @param expression
-     *            The psuedo-xpath expression to test.
+     *            The pseudo-xpath expression to test.
      * @return True if the expression matches the current document position,
      *         otherwise false.
      */
@@ -165,7 +165,7 @@ public boolean testExpression(String expression) {
      * specified stack depth.
      *
      * @param expression
-     *            The psuedo-xpath expression to test.
+     *            The pseudo-xpath expression to test.
      * @param startingStackDepth
      *            The depth in the stack representing where the expression must
      *            start matching in order for this method to return true.

@@ -112,7 +112,7 @@ public void setIsRegionalized(boolean regionalized) {
     }
 
     /**
-     * A convienient method that returns true if a service has a partition
+     * A convenient method that returns true if a service has a partition
      * wide endpoint available.
      */
     public boolean isPartitionWideEndpointAvailable() {

@@ -28,7 +28,7 @@
 @SdkInternalApi
 public final class SdkCborGenerator extends SdkJsonGenerator {
 
-    private static final int CBOR_TAG_TIMESTAP = 1;
+    private static final int CBOR_TAG_TIMESTAMP = 1;
 
     public SdkCborGenerator(JsonFactory factory, String contentType) {
         super(factory, contentType);
@@ -47,7 +47,7 @@ public StructuredJsonGenerator writeValue(Instant instant) {
 
         CBORGenerator generator = (CBORGenerator) getGenerator();
         try {
-            generator.writeTag(CBOR_TAG_TIMESTAP);
+            generator.writeTag(CBOR_TAG_TIMESTAMP);
             generator.writeNumber(instant.toEpochMilli());
         } catch (IOException e) {
             throw new JsonGenerationException(e);

@@ -202,12 +202,12 @@ public void testAsNode() throws Exception {
     public void testMissingNodes() throws Exception {
         Document document = documentFrom(DOCUMENT);
         XPath xpath = XpathUtils.xpath();
-        assertNull(asDouble("non-existant-node/name", document, xpath));
-        assertNull(asLong("non-existant-node/name", document, xpath));
-        assertNull(asInteger("non-existant-node/name", document, xpath));
-        assertNull(asDate("non-existant-node/name", document, xpath));
-        assertNull(asFloat("non-existant-node/name", document, xpath));
-        assertNull(asString("non-existant-node/name", document, xpath));
+        assertNull(asDouble("non-existent-node/name", document, xpath));
+        assertNull(asLong("non-existent-node/name", document, xpath));
+        assertNull(asInteger("non-existent-node/name", document, xpath));
+        assertNull(asDate("non-existent-node/name", document, xpath));
+        assertNull(asFloat("non-existent-node/name", document, xpath));
+        assertNull(asString("non-existent-node/name", document, xpath));
     }
 
     /**

@@ -2,7 +2,7 @@
 
 Operations on the asynchronous clients return [`CompleteableFuture<T>`][1] where `T` is the response type for the operation. This is somewhat curious in that [`CompleteableFuture`][1] is a concrete implementation rather than an interface. The alternative to returning a [`CompleteableFuture`][1] would be to return a [`CompletionStage`][2], an interface intended to allow chaining of asynchronous operations.
 
-The key advantage of [`CompleteableFuture`][1] is that it implements both the [`CompletionStage`][2] and [`Future`][3] interfaces - giving users of the SDK maximum flexibilty when it comes to handling responses from their asynchronous calls.
+The key advantage of [`CompleteableFuture`][1] is that it implements both the [`CompletionStage`][2] and [`Future`][3] interfaces - giving users of the SDK maximum flexibility when it comes to handling responses from their asynchronous calls.
 
 Currently [`CompleteableFuture`][1] is the only implementation of [`CompletionStage`][2] that ships with the JDK. Whilst it's possible that future implementations will be added  [`CompletionStage`][2] will always be tied to [`CompleteableFuture`][1] via the  [`#toCompletableFuture`][4] method. Additionally, [`CompleteableFuture`][1] is not a `final` class and thus could be extended if there was a requirement to do so.
 
@@ -15,4 +15,4 @@ Using [`CompleteableFuture`][1] gives users the best bang for their buck without
 [1]: https://docs.oracle.com/javase/8/docs/api/java/util/concurrent/CompletableFuture.html
 [2]: https://docs.oracle.com/javase/8/docs/api/java/util/concurrent/CompletionStage.html
 [3]: https://docs.oracle.com/javase/7/docs/api/java/util/concurrent/Future.html
-[4]: https://docs.oracle.com/javase/8/docs/api/java/util/concurrent/CompletionStage.html#toCompletableFuture--
+[4]: https://docs.oracle.com/javase/8/docs/api/java/util/concurrent/CompletionStage.html#toCompletableFuture--
@@ -118,7 +118,7 @@ private EventLoopGroup resolveEventLoopGroup(DefaultBuilder builder) {
                                                                                 .build());
         return new NioEventLoopGroup(numThreads, threadFactory);
         /*
-        Need to investigate why epoll is raising channel inactive after succesful response that causes
+        Need to investigate why epoll is raising channel inactive after successful response that causes
         problems with retries.
 
         if (Epoll.isAvailable() && isNotAwsLambda()) {

@@ -1624,7 +1624,7 @@
       "members":{
         "graphqlApi":{
           "shape":"GraphqlApi",
-          "documentation":"<p>The udpated <code>GraphqlApi</code> object.</p>"
+          "documentation":"<p>The updated <code>GraphqlApi</code> object.</p>"
         }
       }
     },

@@ -502,7 +502,7 @@ public void testInstancesAndProcesses() {
 
 
     /**
-     * Tests that we can invoke the notificaiton related operations correctly.
+     * Tests that we can invoke the notification related operations correctly.
      */
 
     @Test

@@ -148,7 +148,7 @@ public void testNullQueryKeyErrorHandling() {
     @Test
     public void testErrorHandling() throws Exception {
 
-        DeleteTableRequest request = DeleteTableRequest.builder().tableName("non-existant-table").build();
+        DeleteTableRequest request = DeleteTableRequest.builder().tableName("non-existent-table").build();
         try {
             dynamo.deleteTable(request);
             fail("Expected an exception to be thrown");

@@ -32,7 +32,7 @@ final class Problem {
     }
 
     /**
-     * @return Context of where this violation occured.
+     * @return Context of where this violation occurred.
      */
     public ValidationContext getContext() {
         return context;

@@ -266,7 +266,7 @@ public void testUpdateItemWithConditionExpression() {
                             // leading to an intentional failure in the update condition
                             .withString(":zipcode", "98104")
                             );
-            fail("Update Should fail as the zip code mentioned in the conditon expression doesn't match");
+            fail("Update Should fail as the zip code mentioned in the condition expression doesn't match");
         } catch (SdkServiceException e) {
             assertTrue(e.getMessage().contains("conditional request failed"));
         }

@@ -162,7 +162,7 @@ public void testBoudaryCases() {
         // The request only contains invalid key pairs
         List<KeyPair> keyPairs = new LinkedList<KeyPair>();
         Class<?> clazz = getUniqueNumericObject().getClass();
-        keyPairs.add(new KeyPair().withHashKey("non-existant-key"));
+        keyPairs.add(new KeyPair().withHashKey("non-existent-key"));
         itemsToGet.clear();
         itemsToGet.put(clazz, keyPairs);
         response = mapper.batchLoad(itemsToGet);
@@ -203,7 +203,7 @@ public BatchGetItemResponse answer(InvocationOnMock invocation) throws Throwable
         DynamoDbMapper mapper = new DynamoDbMapper(mockClient);
         try {
             mapper.batchLoad(objs);
-            fail("Expecting an expection due to exceed of number of retries.");
+            fail("Expecting an exception due to exceed of number of retries.");
         } catch (Exception e) {
             e.printStackTrace();
             long endTime = System.currentTimeMillis();

@@ -16,7 +16,7 @@
 package software.amazon.awssdk.services.dynamodb.datamodeling;
 
 /**
- * Generic exception for problems occuring when mapping DynamoDB items to Java
+ * Generic exception for problems occurring when mapping DynamoDB items to Java
  * objects or vice versa. Excludes service exceptions.
  */
 public class DynamoDbMappingException extends RuntimeException {

@@ -28,7 +28,7 @@
  * {@link DynamoDbTypeConverted} is created per field/attribute. In the old,
  * an new instance of the marshaller was created for each call to
  * {@code marshall} and {@code unmarshall}. If your marshaller/converter is not
- * thread safe, it is recomended to specify a converter which will instantiate
+ * thread safe, it is recommended to specify a converter which will instantiate
  * a new marshaller per call.</p>
  *
  * <pre class="brush: java">

@@ -42,7 +42,7 @@
  * {@link DynamoDbTypeConverted} is created per field/attribute. In the old,
  * an new instance of the marshaller was created for each call to
  * {@code marshall} and {@code unmarshall}. If your marshaller/converter is not
- * thread safe, it is recomended to specify a converter which will instantiate
+ * thread safe, it is recommended to specify a converter which will instantiate
  * a new marshaller per call.</p>
  *
  * <pre class="brush: java">

@@ -37,7 +37,7 @@
     String attributeName() default "";
 
     /**
-     * The scalar attirbute type.
+     * The scalar attribute type.
      * @see software.amazon.awssdk.services.dynamodb.model.ScalarAttributeType
      */
     ScalarAttributeType type();

@@ -109,7 +109,7 @@ public <S, T> DynamoDbTypeConverter<S, T> getConverter(Class<S> sourceType, Clas
     }
 
     /**
-     * Delegate factory to allow selected types to be overriden.
+     * Delegate factory to allow selected types to be overridden.
      */
     private static class OverrideFactory extends DelegateFactory {
         private final ConverterMap overrides;

@@ -78,13 +78,13 @@
  * <p>If the converter being applied is already a supported data type and
  * the conversion is of the same attribute type, for instance,
  * {@link java.util.Date} to {@link String} to {@code S},
- * the annotation may be omited. The annotation is require for all non-standard
- * types or if the attribute type binding is being overriden.</p>
+ * the annotation may be omitted. The annotation is require for all non-standard
+ * types or if the attribute type binding is being overridden.</p>
  *
  * <p><b>{@link software.amazon.awssdk.services.dynamodb.model.AttributeValue}</b></p>
  * <p>Direct native conversion is supported by default in all schemas.
  * If the attribute is a primary or index key, it must specify either
- * {@code B}, {@code N}, or {@code S}, otherwise, it may be omited.</p>
+ * {@code B}, {@code N}, or {@code S}, otherwise, it may be omitted.</p>
  *
  * <p><b>{@link Boolean} to {@code BOOL}</b></p>
  * <p>The standard V2 conversion schema will by default serialize booleans

@@ -1616,7 +1616,7 @@ public void testPojoWithMixedAnnotations() {
     }
 
     /**
-     * Pojo field assersions.
+     * Pojo field assertions.
      */
     private static enum PojoAsserts {
         hashKey(KeyType.HASH, null),

@@ -37,7 +37,7 @@ public class JsonPolicyReader {
 
     private static final String PRINCIPAL_SCHEMA_SERVICE = "Service";
 
-    private static final String PRINICIPAL_SCHEMA_FEDERATED = "Federated";
+    private static final String PRINCIPAL_SCHEMA_FEDERATED = "Federated";
 
     /**
      * Converts the specified JSON string to an AWS policy object.
@@ -247,12 +247,12 @@ private Principal createPrincipal(String schema, JsonNode principalNode) {
             return new Principal(principalNode.asText());
         } else if (schema.equalsIgnoreCase(PRINCIPAL_SCHEMA_SERVICE)) {
             return new Principal(schema, principalNode.asText());
-        } else if (schema.equalsIgnoreCase(PRINICIPAL_SCHEMA_FEDERATED)) {
+        } else if (schema.equalsIgnoreCase(PRINCIPAL_SCHEMA_FEDERATED)) {
             if (Principal.WebIdentityProvider.fromString(principalNode.asText()) != null) {
                 return new Principal(
                         Principal.WebIdentityProvider.fromString(principalNode.asText()));
             } else {
-                return new Principal(PRINICIPAL_SCHEMA_FEDERATED, principalNode.asText());
+                return new Principal(PRINCIPAL_SCHEMA_FEDERATED, principalNode.asText());
             }
         }
         throw new IllegalArgumentException("Schema " + schema + " is not a valid value for the principal.");

@@ -23,11 +23,11 @@ public abstract class WaiterAcceptor<OutputT, ErrorT extends RuntimeException> {
     /**
      * Default method definition that matches the response
      * state with the expected state defined by the acceptor.
-     * Overriden by each acceptor definition of matches.
+     * Overridden by each acceptor definition of matches.
      *
      * @param output Response got by the execution of the operation
      * @return False by default.
-     *     When overriden, returns True if it matches, False
+     *     When overridden, returns True if it matches, False
      *     otherwise
      */
     public boolean matches(OutputT output) {
@@ -37,11 +37,11 @@ public boolean matches(OutputT output) {
     /**
      * Default method definition that matches the exception
      * with the expected state defined by the acceptor.
-     * Overriden by each acceptor definition of matches.
+     * Overridden by each acceptor definition of matches.
      *
      * @param output Exception thrown by the execution of the operation
      * @return False by default.
-     *     When overriden, returns True if it matches, False otherwise
+     *     When overridden, returns True if it matches, False otherwise
      */
     public boolean matches(ErrorT output) {
         return false;
-Original file line number
+Diff line change
@@ Expand Up @@
         }
         /**
-         * Builds the Javadoc string with the current configuraton.
+         * Builds the Javadoc string with the current configuration.
          *
          * @return Formatted Javadoc string.
          */
@@ Expand Down @@