Skip to content

add Automatic-Module-Name to the pom files #775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

zoewangg
Copy link
Contributor

Description

add Automatic-Module-Name to the pom files so that Java 9+ customers

Related to #59

Testing

Tested with a separate modularized java 9 application.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have read the README document
  • I have added tests to cover my changes
  • All new and existing tests passed
  • A short description of the change has been added to the CHANGELOG

License

  • I confirm that this pull request can be released under the Apache 2 license

@zoewangg
Copy link
Contributor Author

Merging conflicts are impossible to fix manually :( Will close and create a new PR.

@zoewangg zoewangg closed this Oct 24, 2018
@zoewangg zoewangg deleted the zoewang-automaticModuleName branch October 24, 2018 17:00
@zoewangg zoewangg restored the zoewang-automaticModuleName branch October 24, 2018 17:00
@zoewangg zoewangg deleted the zoewang-automaticModuleName branch October 29, 2018 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants