Skip to content

Modify S3Object#Size member type from integer to long #943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 11, 2018
Merged

Conversation

varunnvs92
Copy link
Contributor

@varunnvs92 varunnvs92 commented Dec 10, 2018

Description

Fix #917

Changes

  • Move RenameShapesProcessor before other shape modifiers as it removes the original shape from the list of available shapes. If RenameShapesProcessor is not run first, it causes build issues in other shape modifiers.
  • Change Size type from Integer -> Long

The change is breaking to applications who are using the size method currently. We have decided to make the breaking change as this is a bug and breaking change will force the customers to know about this change and update the applications which have incorrect behavior for large objects

@varunnvs92 varunnvs92 requested a review from zoewangg December 10, 2018 23:56
@varunnvs92 varunnvs92 merged commit 2e4a698 into master Dec 11, 2018
@varunnvs92 varunnvs92 deleted the Issue917 branch December 11, 2018 00:16
aws-sdk-java-automation added a commit that referenced this pull request Sep 1, 2020
…1cf85869

Pull request: release <- staging/bc86c3ff-c385-4d45-8499-6d061cf85869
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants