Skip to content

Modify S3Object#Size member type from integer to long #943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 11, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changes/next-release/bugfix-AmazonS3-e1a5575.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
{
"category": "Amazon S3",
"type": "bugfix",
"description": "Modify type of S3Object#size member from integer to long. This is a breaking change for customers who are using the size() method currently"
}
Original file line number Diff line number Diff line change
Expand Up @@ -29,11 +29,11 @@ public static CodegenCustomizationProcessor getProcessorFor(

return new CodegenCustomizationProcessorChain(
new MetadataModifiersProcessor(config.getCustomServiceMetadata()),
new RenameShapesProcessor(config.getRenameShapes()),
new ShapeModifiersProcessor(config.getShapeModifiers()),
new ShapeSubstitutionsProcessor(config.getShapeSubstitutions()),
new OperationModifiersProcessor(config.getOperationModifiers()),
new RemoveExceptionMessagePropertyProcessor(),
new RenameShapesProcessor(config.getRenameShapes())
new RemoveExceptionMessagePropertyProcessor()
);
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,17 @@
"Error" : "S3Error",
"Object" : "S3Object"
},
"shapeModifiers": {
"S3Object": {
"modify":[
{
"Size": {
"emitAsType": "long"
}
}
]
}
},
"serviceSpecificClientConfigClass": "S3Configuration",
"attachPayloadTraitToMember" : {
"GetBucketLocationOutput": "LocationConstraint"
Expand Down