-
Notifications
You must be signed in to change notification settings - Fork 619
feat: add retry-config-provider #1282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1282 +/- ##
==========================================
+ Coverage 73.04% 73.14% +0.09%
==========================================
Files 287 290 +3
Lines 12730 12774 +44
Branches 2922 2933 +11
==========================================
+ Hits 9299 9343 +44
Misses 3431 3431
Continue to review full report at Codecov.
|
Can you verify that its a bug that the tests impact packages/middleware-retry/src/defaultStrategy.ts, and that the unit tests do not actually impact it? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM after minor feedback
Co-authored-by: Alexander Forsyth <[email protected]>
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Issue #, if available:
Internal issue at JS-1813
Description of changes:
adds retry-config-provider to read values from environment or config file:
Similar to region-provider but with following differences:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.