Skip to content

chore: add maxAttemptsDefaultProvider in runtimeConfig #1284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 19, 2020

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Jun 18, 2020

Issue #, if available:
Follow-up to #1282

Description of changes:
adds maxAttemptsDefaultProvider in runtimeConfig

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov-commenter
Copy link

Codecov Report

Merging #1284 into master will increase coverage by 0.10%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1284      +/-   ##
==========================================
+ Coverage   73.04%   73.15%   +0.10%     
==========================================
  Files         287      290       +3     
  Lines       12730    12780      +50     
  Branches     2922     2933      +11     
==========================================
+ Hits         9299     9349      +50     
  Misses       3431     3431              
Impacted Files Coverage Δ
clients/client-s3/S3Client.ts 94.11% <0.00%> (ø)
clients/client-s3/runtimeConfig.ts 100.00% <0.00%> (ø)
packages/region-provider/src/fromEnv.ts 100.00% <0.00%> (ø)
protocol_tests/aws-ec2/runtimeConfig.ts 100.00% <0.00%> (ø)
protocol_tests/aws-json/runtimeConfig.ts 100.00% <0.00%> (ø)
protocol_tests/aws-query/runtimeConfig.ts 100.00% <0.00%> (ø)
protocol_tests/aws-ec2/EC2ProtocolClient.ts 92.30% <0.00%> (ø)
protocol_tests/aws-restxml/runtimeConfig.ts 100.00% <0.00%> (ø)
protocol_tests/aws-restjson/runtimeConfig.ts 100.00% <0.00%> (ø)
protocol_tests/aws-json/JsonProtocolClient.ts 92.30% <0.00%> (ø)
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ecd758a...ebfe6b7. Read the comment docs.

@trivikr trivikr requested a review from alexforsyth June 18, 2020 23:45
Copy link
Contributor

@alexforsyth alexforsyth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Minor comment about the use of any

@trivikr trivikr merged commit c6cd44e into aws:master Jun 19, 2020
@trivikr trivikr deleted the retry-config-provider-codegen-pr branch June 19, 2020 17:59
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants