-
Notifications
You must be signed in to change notification settings - Fork 619
feat: read maxAttempts value from retry-config #1286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: read maxAttempts value from retry-config #1286
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1286 +/- ##
==========================================
+ Coverage 73.04% 73.17% +0.13%
==========================================
Files 287 290 +3
Lines 12730 12792 +62
Branches 2922 2936 +14
==========================================
+ Hits 9299 9361 +62
Misses 3431 3431
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Minor comments to be addressed
d1a896b
to
e11cef7
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Issue #, if available:
Follow-up to #1284
Description of changes:
read maxAttempts value from retry-config
maxAttempts
is now updated fromnumber
toProvider<string>
maxAttempts
is removed fromRetryStrategy
interfaceBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.