Skip to content

chore(clients): move shared interfaces types package #2530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 16, 2021

Conversation

AllanZhengYP
Copy link
Contributor

@AllanZhengYP AllanZhengYP commented Jun 28, 2021

Description

The purpose is to consolidate all SDK public interfaces to the aws-sdk/types package, instead of scatter them to aws-sdk/smithy-client package too. Smithy-client package will still re-export the moved interfaces to ensure backwards compatibility.


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov-commenter
Copy link

codecov-commenter commented Jun 28, 2021

Codecov Report

❗ No coverage uploaded for pull request base (main@c2e88a4). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2530   +/-   ##
=======================================
  Coverage        ?   60.29%           
=======================================
  Files           ?      514           
  Lines           ?    27428           
  Branches        ?     6590           
=======================================
  Hits            ?    16539           
  Misses          ?    10889           
  Partials        ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c2e88a4...1506492. Read the comment docs.

@AllanZhengYP AllanZhengYP force-pushed the document-type-trait branch from d28bb26 to 1506492 Compare July 15, 2021 22:30
@aws-sdk-js-automation
Copy link

AWS CodeBuild CI Report

  • CodeBuild project: sdk-staging-test
  • Commit ID: 1506492
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@trivikr trivikr merged commit fa60bf3 into aws:main Jul 16, 2021
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants