move types from smithy-client package to types package #373
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AllanZhengYP
requested review from
adamthom-amzn,
gosar,
JordonPhillips and
a team
as code owners
|
You should update these as well: https://github.com/awslabs/smithy-typescript/tree/main/smithy-typescript-ssdk-libs |
AllanZhengYP
force-pushed
the
document-type-trait
branch
from
52eeb14 to
39be7fb
Compare
|
This PR is ready again @JordonPhillips |
|
The TS test fails because the change relies on a change in V3 SDK side that not yet released. I will exclude the SSDK change from this PR until V3 is updated. |
JordonPhillips
approved these changes
Jul 13, 2021
trivikr
approved these changes
Jul 15, 2021
srchase
pushed a commit
to srchase/smithy-typescript
that referenced
this pull request
Mar 17, 2023
* move types from smithy-client package to types package * smithy exception import from types package * revert change in ssdk lib and ping dependencies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
The purpose is to consolidate all SDK public interfaces to the
aws-sdk/typespackage.Ref: aws/aws-sdk-js-v3#2530
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.