Skip to content

chore(clients): use clean to remove dist-* folders #3166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 10, 2022

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Jan 10, 2022

Issue

Refs: smithy-lang/smithy-typescript#487

Description

Use clean to remove dist-* folders

Testing

Verified that clean command removes dist-* folder in client-acm

Output
$ client-acm> ls dist-*
dist-cjs:
ACMClient.js  endpoints.js  pagination                runtimeConfig.js         waiters
ACM.js        index.js      protocols                 runtimeConfig.native.js
commands      models        runtimeConfig.browser.js  runtimeConfig.shared.js

dist-es:
ACMClient.js  endpoints.js  pagination                runtimeConfig.js         waiters
ACM.js        index.js      protocols                 runtimeConfig.native.js
commands      models        runtimeConfig.browser.js  runtimeConfig.shared.js

dist-types:
ACMClient.d.ts  endpoints.d.ts  pagination                  runtimeConfig.d.ts         waiters
ACM.d.ts        index.d.ts      protocols                   runtimeConfig.native.d.ts
commands        models          runtimeConfig.browser.d.ts  runtimeConfig.shared.d.ts

$ yarn clean
yarn run v1.22.17
$ rimraf ./dist-*
Done in 0.11s.

$ ls dist-* 
zsh: no matches found: dist-*

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@trivikr trivikr merged commit ac246b5 into aws:main Jan 10, 2022
@trivikr trivikr deleted the update-clean-command branch January 10, 2022 18:08
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants