chore: add updated RDS DATA smithy model #370

AllanZhengYP · 2019-09-19T23:32:11Z

header default middleware
expect continue middleare

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

header default middleware expect continue middleare

AllanZhengYP · 2019-09-19T23:48:01Z

Well, I have to update all middlewares to pass the CI

srchase · 2019-09-26T21:08:45Z

The shapes are failing in a few places:

This one can be resolved by moving to TypeScript 3.7 (tested against Version 3.7.0-dev.20190926)

models/com/amazon/rdsdataservice.ts(31,15): error TS2339: Property 'stringValues' does not exist on type 'Pick<UnknownVariant & { stringValues?: string[] | undefined; booleanValues?: boolean[] | undefined; arrayValues?: Pick<UnknownVariant & ..., never>[] | undefined; blobValues?: Uint8Array[] | undefined; doubleValues?: number[] | undefined; longValues?: number[] | undefined; }, never>'.

Need to update how SmithyException is extending from Error (resolved in Add fixes for symbols and errors smithy-lang/smithy-typescript#3)

models/com/amazon/rdsdataservice.ts(48,12): error TS2416: Property 'message' in type 'BadRequestException' is not assignable to the same property in base type 'SmithyException'.
  Type 'string | undefined' is not assignable to type 'string'.
    Type 'undefined' is not assignable to type 'string'.

Record is a reserved word. The type is aliased to _Record. Record needs to be aliased when referenced within another structure. (resolved in Add fixes for symbols and errors smithy-lang/smithy-typescript#3)

models/com/amazon/rdsdataservice.ts(378,28): error TS2314: Generic type 'Record' requires 2 type argument(s).

Needs further research. Still does not work with 3.7.

models/com/amazon/rdsdataservice.ts(503,13): error TS2456: Type alias 'Value' circularly references itself.

mtdowling · 2019-09-26T21:56:50Z

Need to update how SmithyException is extending from Error (resolved in smithy-lang/smithy-typescript#3)

Fixed in generator

Record is a reserved word. The type is aliased to _Record. Record needs to be aliased when referenced within another structure. (resolved in smithy-lang/smithy-typescript#3)

Fixed in generator

AllanZhengYP · 2019-09-26T22:18:07Z

Record is a reserved word. The type is aliased to _Record. Record needs to be aliased when referenced within another structure. (resolved in smithy-lang/smithy-typescript#3)

Just updated the PR with newest model. The _Record class is not referenced anywhere(https://github.com/AllanFly120/aws-sdk-js-v3/blob/57fc88f8cdc8ee6eff51e2e091c968a4053e6eb8/clients/node/client-rds-data-node/models/com/amazon/rdsdataservice.ts#L378). Is this expected?

* smithy-typescript: ddd6257c956381a8a16fe224d3a9de8286e7ed5f * smithy: 17df2312a0fd9bde2e4c5c0c61c5602cd20bc27f

AllanZhengYP · 2019-09-27T22:02:02Z

clients/node/client-rds-data-node/protocol/AwsRestJson1_1.ts

+): ExecuteStatementResponse {
+  let data: any = {};
+  if (output.body) {
+    data = JSON.parse(output.body);


Here the output.body is not a binary data. It's actually Readable in node and Blob in browser. You should call streamcollector transfer them into binary. Example can be found here:

aws-sdk-js-v3/packages/protocol-rest/src/RestParser.ts

Lines 215 to 234 in 226e544

private resolveBody(

body: HttpResponse<StreamType>["body"] = ""

): Promise<Uint8Array | string> {

if (typeof body === "string") {

return Promise.resolve(body);

}

let bufferPromise: Promise<Uint8Array>;

if (ArrayBuffer.isView(body)) {

bufferPromise = Promise.resolve(

new Uint8Array(body.buffer, body.byteOffset, body.byteLength)

);

} else if (isArrayBuffer(body)) {

bufferPromise = Promise.resolve(new Uint8Array(body, 0, body.byteLength));

} else {

bufferPromise = this.bodyCollector(body);

}

return bufferPromise;

}

, You may need to import a runtime-specific stream collector like node collector and browser collector

AllanZhengYP · 2019-09-27T22:05:08Z

clients/node/client-rds-data-node/protocol/AwsRestJson1_1.ts

+  });
+}
+
+export function executeStatementAwsRestJson1_1Deserialize(


Deserializers should be async functions that return a promise according to our definition

…Fly120/aws-sdk-js-v3 into zheallan-smithy-codegen

codecov-io · 2019-10-02T18:21:38Z

Codecov Report

❗ No coverage uploaded for pull request base (smithy-codegen@20081b7). Click here to learn what that means.
The diff coverage is 92.3%.

@@                Coverage Diff                @@
##             smithy-codegen     #370   +/-   ##
=================================================
  Coverage                  ?   97.28%           
=================================================
  Files                     ?       69           
  Lines                     ?     1177           
  Branches                  ?      215           
=================================================
  Hits                      ?     1145           
  Misses                    ?       32           
  Partials                  ?        0

Impacted Files	Coverage Δ
...kages/fetch-http-handler/src/fetch-http-handler.ts	`97.61% <100%> (ø)`
packages/retry-middleware/src/retryMiddleware.ts	`100% <100%> (ø)`
...ackages/node-http-handler/src/node-http-handler.ts	`96.42% <100%> (ø)`
packages/middleware-header-default/src/index.ts	`91.66% <87.5%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 20081b7...1465a66. Read the comment docs.

AllanZhengYP · 2019-10-02T18:23:54Z

The (de)serializer looks good to me. 🚢

mtdowling · 2019-10-02T18:28:12Z

clients/node/client-rds-data-node/lib/smithy.ts

@@ -0,0 +1,44 @@
+export const TYPE = "__type";


I think we could move this file into a shared package in the future. This is fine for now.

mtdowling · 2019-10-02T18:32:40Z

clients/node/client-rds-data-node/package.json

@@ -68,6 +69,6 @@
    "rollup-plugin-replace": "^2.2.0",
    "rollup-plugin-sourcemaps": "^0.4.2",
    "typedoc": "^0.14.2",
-    "typescript": "~3.4.0"
+    "typescript": "^3.7.0-dev.20190926"


Probably shouldn't rely on a dev build

mtdowling · 2019-10-02T18:35:47Z

clients/node/client-rds-data-node/protocol/AwsRestJson1_1.ts

+export function executeStatementAwsRestJson1_1Serialize(
+  input: ExecuteStatementRequest
+): HttpRequest {
+  let body: any = {};


A performance improvement here would be to use a streaming JSON serializer rather than needing to store the JSON object in an intermediate value. This should be done at some point but isn't a blocker right now.

mtdowling · 2019-10-02T18:42:24Z

clients/node/client-rds-data-node/protocol/AwsRestJson1_1.ts

+  });
+}
+
+function executeStatementAwsRestJson1_1DeserializeError(


I think this needs work. It should check the x-amzn-ErrorType header for the ID of the error and use that. If that's not found, then it should fall back to status codes.

lock · 2019-10-09T19:04:44Z

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

AllanZhengYP added 2 commits September 19, 2019 16:30

chore: add http request type guard for middlewares

e88a823

header default middleware expect continue middleare

chore: run test-all script in ci

e0d2b1d

AllanZhengYP added the smithy-codegen Changes regarding supporting smithy model. Will be merged to smithy-codegen branch label Sep 19, 2019

AllanZhengYP changed the title ~~chore: add http request type guard for middlewares~~ chore: add http request type guard to middlewares Sep 19, 2019

AllanZhengYP added 4 commits September 20, 2019 08:31

chore: add http request type guard for apply body checksum middlewares

20f85c4

chore: only build and test demo smithy client

97523de

feat: add isInstance to httpResponse

55bec88

chore: update rds data model

9c20ebc

AllanZhengYP force-pushed the smithy-codegen branch from f4f36c7 to 9c20ebc Compare September 26, 2019 16:51

AllanZhengYP changed the title ~~chore: add http request type guard to middlewares~~ chore: add updated RDS DATA smithy model Sep 26, 2019

AllanZhengYP force-pushed the smithy-codegen branch 2 times, most recently from 6f7f964 to 96bb132 Compare September 26, 2019 22:46

AllanZhengYP added 2 commits September 26, 2019 15:47

chore: update to ts3.7; update rds model#3

96bb132

* smithy-typescript: ddd6257c956381a8a16fe224d3a9de8286e7ed5f * smithy: 17df2312a0fd9bde2e4c5c0c61c5602cd20bc27f

chore: update tsconfig to genenerte types only once

c60241b

AllanZhengYP commented Sep 27, 2019

View reviewed changes

Chase Coalwell and others added 2 commits September 27, 2019 15:09

chore: update rds model#4

7dba143

Merge branch 'AllanFly120-smithy-codegen' of https://github.com/Allan…

0674245

…Fly120/aws-sdk-js-v3 into zheallan-smithy-codegen

AllanZhengYP force-pushed the smithy-codegen branch from 8081286 to c60241b Compare September 27, 2019 22:52

AllanZhengYP and others added 7 commits September 27, 2019 16:00

fix: fix merging issue

f84b949

chore: update gitignore

c722411

chore: parse body with streamCollector

5e2a707

chore: add error deserialization

f3f2833

chore: stub Field union

ee5e5b9

fix: fix middleware-header-default test

d14ef86

fix: fix retry-middleware unit test

1465a66

AllanZhengYP merged commit 2b77246 into aws:smithy-codegen Oct 2, 2019

mtdowling reviewed Oct 2, 2019

View reviewed changes

lock bot locked as resolved and limited conversation to collaborators Oct 9, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

chore: add updated RDS DATA smithy model #370

chore: add updated RDS DATA smithy model #370

Uh oh!

AllanZhengYP commented Sep 19, 2019

Uh oh!

AllanZhengYP commented Sep 19, 2019

Uh oh!

srchase commented Sep 26, 2019 •

edited

Loading

Uh oh!

mtdowling commented Sep 26, 2019

Uh oh!

AllanZhengYP commented Sep 26, 2019 •

edited

Loading

Uh oh!

AllanZhengYP Sep 27, 2019

Uh oh!

AllanZhengYP Sep 27, 2019

Uh oh!

codecov-io commented Oct 2, 2019

Uh oh!

AllanZhengYP commented Oct 2, 2019

Uh oh!

mtdowling Oct 2, 2019

Uh oh!

mtdowling Oct 2, 2019

Uh oh!

mtdowling Oct 2, 2019

Uh oh!

mtdowling Oct 2, 2019

Uh oh!

lock bot commented Oct 9, 2019

Uh oh!

Uh oh!

	private resolveBody(
	body: HttpResponse<StreamType>["body"] = ""
	): Promise<Uint8Array \| string> {
	if (typeof body === "string") {
	return Promise.resolve(body);
	}

	let bufferPromise: Promise<Uint8Array>;
	if (ArrayBuffer.isView(body)) {
	bufferPromise = Promise.resolve(
	new Uint8Array(body.buffer, body.byteOffset, body.byteLength)
	);
	} else if (isArrayBuffer(body)) {
	bufferPromise = Promise.resolve(new Uint8Array(body, 0, body.byteLength));
	} else {
	bufferPromise = this.bodyCollector(body);
	}

	return bufferPromise;
	}

chore: add updated RDS DATA smithy model #370

chore: add updated RDS DATA smithy model #370

Uh oh!

Conversation

AllanZhengYP commented Sep 19, 2019

Uh oh!

AllanZhengYP commented Sep 19, 2019

Uh oh!

srchase commented Sep 26, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mtdowling commented Sep 26, 2019

Uh oh!

AllanZhengYP commented Sep 26, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

AllanZhengYP Sep 27, 2019

Choose a reason for hiding this comment

Uh oh!

AllanZhengYP Sep 27, 2019

Choose a reason for hiding this comment

Uh oh!

codecov-io commented Oct 2, 2019

Codecov Report

Uh oh!

AllanZhengYP commented Oct 2, 2019

Uh oh!

mtdowling Oct 2, 2019

Choose a reason for hiding this comment

Uh oh!

mtdowling Oct 2, 2019

Choose a reason for hiding this comment

Uh oh!

mtdowling Oct 2, 2019

Choose a reason for hiding this comment

Uh oh!

mtdowling Oct 2, 2019

Choose a reason for hiding this comment

Uh oh!

lock bot commented Oct 9, 2019

Uh oh!

Uh oh!

srchase commented Sep 26, 2019 •

edited

Loading

AllanZhengYP commented Sep 26, 2019 •

edited

Loading