Add fixes for symbols and errors #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Reserved words are now escaped in the symbol visitor to account for escaping reserved words in symbol references (like a list of Record becomes "Array<_Record>". 2. Error structures now normalize the "message" member regardless of the model. This prevents typing issues with super. 3. "message" is no longer generated as a property of SmithyException subtypes. 4. Fixed a bug in how relative module imports were handled and simplified turning module names into file names. Now the module name of shapes that are generated always contains "index" to fix relativizing imports.
srchase
approved these changes
Sep 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
escaping reserved words in symbol references (like a list of Record
becomes "Array<_Record>".
model. This prevents typing issues with super.
subtypes.
simplified turning module names into file names. Now the module name
of shapes that are generated always contains "index" to fix
relativizing imports.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.