fix(middleware-sdk-s3): process errors with 200 status code #3874
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trivikr
changed the title
This comment was marked as outdated.
This comment was marked as outdated.
trivikr
requested changes
Aug 23, 2022
siddsriv
force-pushed
the
s3-middleware-200-exception-test
branch
from
7db0784 to
3d58b5f
Compare
|
(force) push above -- that refactors the tests. Needs more work before PR. |
siddsriv
force-pushed
the
s3-middleware-200-exception-test
branch
from
3d58b5f to
7927365
Compare
trivikr
requested changes
Aug 25, 2022
added 5 commits
August 29, 2022 18:06
…all failed requests
…us codes< 200 and >= 300
…ixed. all tests passing
siddsriv
force-pushed
the
s3-middleware-200-exception-test
branch
from
7927365 to
8afcb69
Compare
AllanZhengYP
approved these changes
Aug 29, 2022
kuhe
approved these changes
Aug 29, 2022
trivikr
approved these changes
Sep 6, 2022
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Fixes: #3856
Description
Process errors with 200 status code in throw200ExceptionsMiddleware
Testing
Unit testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.