Config Refactoring

[jeremeamia]

The way configuration is provided to the service provider needs to be updated. This issue and an accompanying PR that I'm working on will be used to replace #15, #8, and #7. Thanks to @AndreasHeiberg, @iricketson, @trackops, and @rtablada for their contributions towards this issue already. I should have a PR soon for you to check out.

[rtablada]

@jeremeamia not sure that a breaking change is necessary. I like the ability to check if there are settings in config/aws.php in case someone may want to have more up front configuration.

something like $app['config']['aws.some_property'] ? $app['config']['aws.some_property'] : $app['config']['aws-sdk-php-laravel::some_property'] should work and allow both (though it has a bit of a downside in performance by doing two file reads if config/aws.php does not have a proper config file...

[andheiberg]

@rtablada wouldn't you have to also make a conditional config registration in the service providers register method?

    if (! $this->app['config']['aws'])
    {
        $this->app['config']->package('aws/aws-sdk-php-laravel', __DIR__.'/../../config');
    }

It would be way easier in my opinion to just stick with the package config

[rtablada]

Nope, you register the package no matter what in the boot method:

$this->package('aws/aws-sdk-php-laravel');

[andheiberg]

@rtablada right cause it will just fallback to the one in the package folder anyway.... :) didn't think it through

[jeremeamia]

@rtablada and @AndreasHeiberg, please checkout the PR and let me know what you think. With this setup, the package config should be available via Config::get('aws::config').

[jeremeamia]

Also, in my testing I noticed that the Manual instantiation section of the README actually doesn't work. If you do this, the entire Config/Repository object gets overridden. I'll make sure to revamp that section.

[jeremeamia]

Tagged in 1.1.0.