Updated configuration handling

[iricketson]

Updated the service provider to be more inline with standard laravel configuration handling.

[jeremeamia]

Thanks! I'm having trouble getting the tests to pass though. Were they passing for you?

[jeremeamia]

Also, I have been asked to have you confirm that you are submitting this code under the Apache 2.0 license. Thanks.

[jeremeamia]

@iricketson Ping!

[iricketson]

Sorry I have been out, I'll take a look.

[jeremeamia]

Any progress? I'd also like to get the opinion of @taylorotwell about this PR. I'm not a Laravel expert, so I like to get multiple opinions on features/changes focused on Laravel idioms.

[iricketson]

@jeremeamia Are you developing this package via the laravel workbench? I see you have some hard coded pathing in bootstrap.php which is making it difficult to run tests from the workbench environment.

[jeremeamia]

Nope, that either didn't exist or was not documented when I first wrote the service provider. I'm also not really a Laravel developer, so it's possible I missed it completely. That bootstrap file is designed to be used with phpunit, assuming that you've cloned that package and run composer install. What suggestions do you have?

[jeremeamia]

@iricketson @taylorotwell Sorry this PR has just been sitting here. I'd like some more direction on what to do though. What all needs to change to work with Laravel Workbench? Is Laravel Workbench a requirement?

[rtablada]

I will work on a modified version of this as this PR would break backwards compatibility. However, I will make a way to allow both configuration options with the old configuration taking preference since the package configuration syntax will default into the vendor configuration if it was the first-class-citizen.

[jeremeamia]

@rtablada What about #15? How does it compare to this PR or your proposed PR?

[jeremeamia]

Thanks for your work on this. I'm closing this in favor of #17 which has more complete testing around the changes.