Skip to content

Refactoring config to support package-level configuration. #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Sep 4, 2013

Conversation

jeremeamia
Copy link
Contributor

No description provided.

@jeremeamia jeremeamia mentioned this pull request Aug 31, 2013
@rtablada
Copy link

rtablada commented Sep 4, 2013

Looks good to me. You don't need the ?: array() when grabbing configs since the aws::config will never return a falsey value.

jeremeamia added a commit that referenced this pull request Sep 4, 2013
Refactoring config to support package-level configuration. Fixes #17.
@jeremeamia jeremeamia merged commit a1429fd into master Sep 4, 2013
@jeremeamia jeremeamia deleted the refactor-config branch February 18, 2015 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request A feature should be added or improved.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants