add elastic inference test #11
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurenyu
reviewed
May 21, 2019
test/conftest.py
Outdated
| @@ -33,7 +32,7 @@ | |||
| def pytest_addoption(parser): | |||
| parser.addoption('--docker-base-name', default='preprod-mxnet-serving') | |||
| parser.addoption('--region', default='us-west-2') | |||
| parser.addoption('--framework-version', default=MXNet.LATEST_VERSION) | |||
| parser.addoption('--framework-version', default='1.4.0') | |||
There was a problem hiding this comment.
I'd move this to a constant up top. also make sure this is noted in our internal documentation as a place where the framework version needs to be manually updated.
|
|
||
| @pytest.mark.skip_if_non_supported_ei_region | ||
| @pytest.mark.skip_if_no_accelerator | ||
| def test_deploy_elastic_inference_with_pretrained_model(pretrained_model_data, ecr_image, sagemaker_session, |
There was a problem hiding this comment.
you could just call this test_deploy_elastic_inference. All of the tests in this repo start with a pretrained model.
laurenyu
approved these changes
May 21, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on: https://github.com/aws/sagemaker-mxnet-container/blob/master/test/integration/sagemaker/test_elastic_inference.py
Dependent on this PR: https://github.com/aws/sagemaker-python-sdk/pull/810/files
Going to need to pin the version in setup.py.