add readme #13
Merged
add readme #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurenyu
reviewed
May 23, 2019
README.rst
Outdated
|
|
||
| The Dockerfiles in this repository are intended to be used for building Docker images to run inference endpoints on `Amazon SageMaker <https://aws.amazon.com/documentation/sagemaker/>`__. | ||
|
|
||
| The current master branch of this repository contains Dockerfiles and support code for MXNet versions 1.4.0 and higher. |
There was a problem hiding this comment.
maybe add a link to the other repo for versions 1.3.0 and lower?
There was a problem hiding this comment.
There is a link above.
README.rst
Outdated
| # GPU | ||
| docker build -t preprod-mxnet-serving:<tag> \ | ||
| --build-arg py_version=<python_version> \ | ||
| -f docker/<MXNet_version>/final/Dockerfile.gpu . |
There was a problem hiding this comment.
I'd lowercase "MXNet" here - "MXNet_version" looks weird to me
README.rst
Outdated
|
|
||
| Support for using MXNet with Amazon Elastic Inference in SageMaker is supported in the public SageMaker MXNet containers. | ||
|
|
||
| * For information on how to use the Python SDK to create an endpoint with Amazon Elastic Inference and MXNet in SageMaker, see `Deploying MXNet Models <https://github.com/aws/sagemaker-python-sdk/tree/master/src/sagemaker/mxnet#deploying-mxnet-models>`__. |
There was a problem hiding this comment.
this link doesn't work anymore
laurenyu
approved these changes
May 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on https://github.com/aws/sagemaker-mxnet-container
Will add section on testing sagemaker end to end tests and elastic inference, in this PR: #11
Checking distribution dist/sagemaker_mxnet_serving_container-1.0.0.tar.gz: Passed