change: enable Neo integ tests #1309
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change also fixes the logic for generating a model name when compiling a model if self.name is not already set.
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
knakad
approved these changes
Feb 25, 2020
| @@ -286,7 +286,7 @@ def alternative_cpu_instance_type(sagemaker_session, request): | |||
|
|
|||
| @pytest.fixture(scope="session") | |||
| def cpu_instance_family(cpu_instance_type): | |||
| "_".join(cpu_instance_type.split(".")[0:2]) | |||
| return "_".join(cpu_instance_type.split(".")[0:2]) | |||
|
|
||
|
|
||
| ### NOTE: this function cannot use MXNet | ||
| # NOTE: this function cannot use MXNet |
There was a problem hiding this comment.
[INFO] For prod code, I'd probably also modify this to actually print something out, because that's much more discoverable than the comment. Not worth the effort for a test script, though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
These tests were introduced as part of re:Invent 2018 (#513). We have the necessary AWS SDK version for these tests, and so after 15 months I think we should probably enable them 😂
This change also fixes the logic for generating a model name when compiling a model if
self.nameis not already set.Testing done:
pytest tests/integ/test_neo_mxnet.pyMerge Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.General
Tests
unique_name_from_baseto create resource names in integ tests (if appropriate)By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.