Update docstrings of logs_for_job and train methods #157
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #157 +/- ##
=======================================
Coverage 90.63% 90.63%
=======================================
Files 37 37
Lines 2478 2478
=======================================
Hits 2246 2246
Misses 232 232
Continue to review full report at Codecov.
|
laurenyu
reviewed
Apr 19, 2018
src/sagemaker/session.py
Outdated
| instance_count (int): Number of EC2 instances to use for training. | ||
| instance_type (str): Type of EC2 instance to use for training, for example, 'ml.c4.xlarge'. | ||
| instance_count (int): Number of EC2 instances to use for training. | ||
| instance_type (str): Type of EC2 instance to use for training, for example, 'ml.c4.xlarge'. |
There was a problem hiding this comment.
Can you put these in a bulleted list?
apacker
pushed a commit
to apacker/sagemaker-python-sdk
that referenced
this pull request
Nov 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update docstrings of
logs_for_jobandtrainmethods.Merge Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.