feature: add BaseSerializer and BaseDeserializer #1668

bveeramani · 2020-07-02T23:44:10Z

Issue #, if available:

Description of changes:

Added sagemaker.serializers.BaseSerializer
Added sagemaker.serializers.BaseDeserializer
Added sagemaker.predictor.LegacySerialzier
Added sagemaker.predictor.LegacyDeserializer
Changed implementation of sagemaker.predictor.Predictor.__init__
Changed implementation of sagemaker.predictor.Predictor._handle_response
Changed implementation of sagemaker.predictor.Predictor._create_request_args

Testing done:

Created and added two tests to tests.unit.sagemaker.test_serializers
Created and added two tests to tests.unit.sagemaker.test_deserializers

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

I have read the CONTRIBUTING doc
I used the commit message format described in CONTRIBUTING
I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

I have added tests that prove my fix is effective or that my feature works (if appropriate)
I have checked that my tests are not configured for a specific region or account (if appropriate)
I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

sagemaker-bot · 2020-07-02T23:51:26Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 3bc8575
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-07-03T00:10:20Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 3bc8575
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-07-03T00:46:22Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 3bc8575
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

src/sagemaker/deserializers.py

src/sagemaker/predictor.py

tests/unit/sagemaker/test_deserializers.py

src/sagemaker/deserializers.py

sagemaker-bot · 2020-07-03T01:23:57Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-zwei-pr
Commit ID: 3bc8575
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-07-03T07:18:23Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 2d69f65
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-07-03T07:37:36Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 2d69f65
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-07-03T08:13:45Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 2d69f65
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-07-03T08:18:35Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-zwei-pr
Commit ID: 2d69f65
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

src/sagemaker/predictor.py

…del.transformer() (#1666) This also changes how model and endpoint names are generated for compiled models, and removes the unused private attribute model._model_name.

sagemaker-bot · 2020-07-06T18:24:43Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: bd909bb
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-07-06T18:44:50Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: bd909bb
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-07-06T19:18:41Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: bd909bb
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-07-06T19:26:07Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-zwei-pr
Commit ID: bd909bb
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-07-06T19:33:59Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: cb249f8
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-07-06T20:08:28Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: cb249f8
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-07-06T20:16:03Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-zwei-pr
Commit ID: cb249f8
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-07-06T20:27:21Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: cb249f8
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-07-06T20:40:48Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 8072555
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-07-06T21:00:03Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 8072555
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-07-06T21:09:53Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-zwei-pr
Commit ID: 8072555
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-07-06T21:13:49Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 8072555
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-07-06T23:17:49Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: d6fa55d
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-07-06T23:38:10Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: d6fa55d
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-07-06T23:40:59Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-zwei-pr
Commit ID: d6fa55d
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-07-06T23:49:02Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: d6fa55d
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

laurenyu

looks good to me - just a couple small comments

laurenyu · 2020-07-07T15:25:31Z

src/sagemaker/predictor.py

+    """Wrapper that makes legacy serializers forward compatibile."""
+
+    def __init__(self, serializer):
+        """Placeholder docstring.


don't forget to fill this in :)

laurenyu · 2020-07-07T15:27:22Z

src/sagemaker/predictor.py

+        self.serializer = serializer
+        self.content_type = getattr(serializer, "content_type", None)
+
+    def __call__(self, *args, **kwargs):


are the function signatures that different across legacy implementations? I think it would be better to avoid *args and **kwargs here if possible.

Some of the classes have different function signatures. For example, _NPYSerializer has the signature def __call__(self, data, dtype=None). If I were to not use *args and **kwargs, then I would need to make changes (or remove) some tests. Since LegacySerializer and LegacyDeserializer are temporary fixes so that I can make incremental changes, IMO I think it's fine.

metrizable · 2020-07-07T16:10:11Z

src/sagemaker/deserializers.py

+    @property
+    @abc.abstractmethod
+    def ACCEPT(self):
+        """The content type that is expected from the inference endpoint."""


have you given any more thought on how to support serdes (serializers/deserializers) that can and should be able to accept and operate on a collection of content types?

Yeah, the user will be able to specify a string, list, or dictionary of accept types. Because adding support for multiple accept types necessitates changes to the sagemaker-inference-toolkit, I'm planning on first migrating the existing serializers/deserializers (which have only one accept type) and then adding support for multiple accept types.

sagemaker-bot · 2020-07-07T17:43:47Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 148c1e9
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-07-07T17:59:20Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 539978d
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-07-07T18:03:31Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 148c1e9
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-07-07T18:15:35Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 148c1e9
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-07-07T18:20:18Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 539978d
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-07-07T18:28:20Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-zwei-pr
Commit ID: 539978d
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-07-07T18:31:34Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 539978d
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

* Remove property@ decorator from ABC definition. * Cache client as instance attribute in @Property. * Fix flake8 issue. --------- Co-authored-by: Joseph Zhang <[email protected]>

…image. (#5143) * feature:support custom workflow deployment in ModelBuilder using SMD image. (#1661) * feature:support custom workflow deployment in ModelBuilder using SMD inference image. * Rename test case and pass session. * Address PR comments. * Tweak resource cleanup logic in integ test. * Fixing CodeBuild integ test failures. * Renamed integ test. * Remove unused integ test, restore once GA. --------- Co-authored-by: Joseph Zhang <[email protected]> * Cache client as instance attribute in property@ decorator. (#1668) * Remove property@ decorator from ABC definition. * Cache client as instance attribute in @Property. * Fix flake8 issue. --------- Co-authored-by: Joseph Zhang <[email protected]> * Bugfixes from e2e testing. (#1670) * Fix Alabtross Inference component tests * trigger integ tests --------- Co-authored-by: cj-zhang <[email protected]> Co-authored-by: Joseph Zhang <[email protected]> Co-authored-by: Pravali Uppugunduri <[email protected]>

Add SerDe base classes

3bc8575

metrizable suggested changes Jul 3, 2020

View reviewed changes

Merge branch 'zwei' into add-serde-base-classes

2d69f65

laurenyu reviewed Jul 6, 2020

View reviewed changes

src/sagemaker/predictor.py Show resolved Hide resolved

src/sagemaker/predictor.py Show resolved Hide resolved

laurenyu and others added 3 commits July 6, 2020 13:17

breaking: create new inference resources during model.deploy() and mo…

0717895

…del.transformer() (#1666) This also changes how model and endpoint names are generated for compiled models, and removes the unused private attribute model._model_name.

breaking: rename image_name to image_uri (#1667)

a5fd621

Address review comments

bd909bb

Appease integration tests

cb249f8

Appease integration tests

8072555

Merge branch 'zwei' into add-serde-base-classes

d6fa55d

bveeramani requested a review from laurenyu July 6, 2020 23:10

bveeramani changed the title ~~[WIP] breaking: add BaseSerializer and BaseDeserializer~~ feature: add BaseSerializer and BaseDeserializer Jul 7, 2020

laurenyu reviewed Jul 7, 2020

View reviewed changes

laurenyu requested a review from metrizable July 7, 2020 15:29

metrizable reviewed Jul 7, 2020

View reviewed changes

Merge branch 'zwei' into add-serde-base-classes

148c1e9

Remove placeholder docstring

539978d

metrizable approved these changes Jul 7, 2020

View reviewed changes

laurenyu approved these changes Jul 7, 2020

View reviewed changes

bveeramani merged commit 1487b22 into aws:zwei Jul 7, 2020

bveeramani deleted the add-serde-base-classes branch July 7, 2020 18:50

bveeramani mentioned this pull request Aug 3, 2020

Expose better JsonSerde for endpoint invocation #1351

Closed

feature: add BaseSerializer and BaseDeserializer #1668

feature: add BaseSerializer and BaseDeserializer #1668

Uh oh!

Conversation

bveeramani commented Jul 2, 2020

Merge Checklist

General

Tests

Uh oh!

sagemaker-bot commented Jul 2, 2020

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jul 3, 2020

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jul 3, 2020

AWS CodeBuild CI Report

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sagemaker-bot commented Jul 3, 2020

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jul 3, 2020

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jul 3, 2020

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jul 3, 2020

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jul 3, 2020

AWS CodeBuild CI Report

Uh oh!

Uh oh!

Uh oh!

sagemaker-bot commented Jul 6, 2020

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jul 6, 2020

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jul 6, 2020

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jul 6, 2020

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jul 6, 2020

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jul 6, 2020

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jul 6, 2020

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jul 6, 2020

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jul 6, 2020

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jul 6, 2020

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jul 6, 2020

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jul 6, 2020

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jul 6, 2020

metrizable Jul 7, 2020 •

edited

Loading