breaking: rename image to image_uri #1670

laurenyu · 2020-07-06T20:53:36Z

Issue #, if available:
#1473

Description of changes:
part 2 to #1667. doc changes will be in a separate PR because I already changed 63 files here and docs would be another 17 files. migration tool changes will also be in a separate PR because 63 files is a lot.

I also chose to change deployment_image and primary_container_image to image_uri for consistency.

Testing done:
unit tests, linters

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

I have read the CONTRIBUTING doc
I used the commit message format described in CONTRIBUTING
I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

I have added tests that prove my fix is effective or that my feature works (if appropriate)
I have checked that my tests are not configured for a specific region or account (if appropriate)
I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

sagemaker-bot · 2020-07-06T20:56:03Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 5b37502
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-07-06T21:20:27Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 5b37502
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-07-06T21:21:23Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 2035b52
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-07-06T21:25:01Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 2035b52
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-07-06T21:32:48Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 5b37502
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-07-06T21:33:44Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-zwei-pr
Commit ID: 2035b52
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-07-06T21:36:41Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 2035b52
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-07-06T21:49:05Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: e3b93cb
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-07-06T21:54:46Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 495837d
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-07-06T22:12:40Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: e3b93cb
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-07-06T22:17:55Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 495837d
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-07-06T22:28:00Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: e3b93cb
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-07-06T22:29:14Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-zwei-pr
Commit ID: 495837d
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-07-06T22:34:20Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 495837d
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-07-07T00:26:48Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 1c75a4d
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-07-07T00:46:02Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 1c75a4d
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-07-07T00:58:43Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 1c75a4d
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-07-07T01:13:55Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-zwei-pr
Commit ID: 1c75a4d
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

metrizable

ship it

…image. (#5143) * feature:support custom workflow deployment in ModelBuilder using SMD image. (#1661) * feature:support custom workflow deployment in ModelBuilder using SMD inference image. * Rename test case and pass session. * Address PR comments. * Tweak resource cleanup logic in integ test. * Fixing CodeBuild integ test failures. * Renamed integ test. * Remove unused integ test, restore once GA. --------- Co-authored-by: Joseph Zhang <[email protected]> * Cache client as instance attribute in property@ decorator. (#1668) * Remove property@ decorator from ABC definition. * Cache client as instance attribute in @Property. * Fix flake8 issue. --------- Co-authored-by: Joseph Zhang <[email protected]> * Bugfixes from e2e testing. (#1670) * Fix Alabtross Inference component tests * trigger integ tests --------- Co-authored-by: cj-zhang <[email protected]> Co-authored-by: Joseph Zhang <[email protected]> Co-authored-by: Pravali Uppugunduri <[email protected]>

breaking: rename image to image_uri for models

5b37502

black format

2035b52

laurenyu mentioned this pull request Jul 6, 2020

doc: update documentation for image_name/image --> image_uri #1671

Merged

7 tasks

laurenyu changed the title ~~breaking: rename image to image_uri for models~~ breaking: rename image to image_uri Jul 6, 2020

primary_container_image_uri/deployment_image_uri --> image_uri

e3b93cb

rename one more deployment_image_uri

495837d

metrizable previously approved these changes Jul 6, 2020

View reviewed changes

black format

1c75a4d

laurenyu dismissed metrizable’s stale review via 1c75a4d July 7, 2020 00:19

laurenyu requested a review from metrizable July 7, 2020 01:01

metrizable approved these changes Jul 7, 2020

View reviewed changes

laurenyu merged commit 4d4dd1f into aws:zwei Jul 7, 2020

laurenyu deleted the image branch July 7, 2020 16:58

This was referenced Jul 7, 2020

change: handle image_uri rename in Airflow model config functions in v2 migration tool #1673

Merged

change: handle image_uri rename for estimators and models in v2 migration tool #1675

Merged

change: handle image_uri rename for Session methods #1681

Merged

pravali96 pushed a commit to pravali96/sagemaker-python-sdk that referenced this pull request Apr 21, 2025

Bugfixes from e2e testing. (aws#1670)

4c3ac4c

pravali96 pushed a commit to pravali96/sagemaker-python-sdk that referenced this pull request Apr 23, 2025

Bugfixes from e2e testing. (aws#1670)

e66e77e

pravali96 pushed a commit to pravali96/sagemaker-python-sdk that referenced this pull request Apr 24, 2025

Bugfixes from e2e testing. (aws#1670)

601bdbe

breaking: rename image to image_uri #1670

breaking: rename image to image_uri #1670

Uh oh!

Conversation

laurenyu commented Jul 6, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge Checklist

General

Tests

Uh oh!

sagemaker-bot commented Jul 6, 2020

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jul 6, 2020

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jul 6, 2020

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jul 6, 2020

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jul 6, 2020

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jul 6, 2020

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jul 6, 2020

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jul 6, 2020

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jul 6, 2020

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jul 6, 2020

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jul 6, 2020

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jul 6, 2020

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jul 6, 2020

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jul 6, 2020

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jul 7, 2020

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jul 7, 2020

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jul 7, 2020

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jul 7, 2020

AWS CodeBuild CI Report

Uh oh!

metrizable left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

laurenyu commented Jul 6, 2020 •

edited

Loading