fix: check optional keyword before accessing #1911

chuyang-deng · 2020-09-21T04:06:51Z

Issue #, if available:
#1910

Description of changes:
Check optional Keyword Environment, NetworkConfig before accessing them in ModelMonitor.attach

Testing done:
tox -e py36 -- tests/unit

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

I have read the CONTRIBUTING doc
I used the commit message format described in CONTRIBUTING
I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

I have added tests that prove my fix is effective or that my feature works (if appropriate)
I have checked that my tests are not configured for a specific region or account (if appropriate)
I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

sagemaker-bot · 2020-09-21T04:14:43Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: f3027ca
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-09-21T04:32:54Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: f3027ca
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-09-21T04:46:47Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: f3027ca
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-09-21T05:11:51Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: f3027ca
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

icywang86rui · 2020-09-21T17:27:56Z

This attached function is over 100 lines long now. Should we move some of the dict parsing stuff out or maybe model the DescribeSchedule call output into a class and do all the parsing there?

icywang86rui · 2020-09-21T17:24:16Z

src/sagemaker/model_monitor/model_monitoring.py

-        ].get("VpcConfig")
+        vpc_config = None
+        if (
+            schedule_desc["MonitoringScheduleConfig"]["MonitoringJobDefinition"].get(


should this be just if network_config_dict is not None

I would also put all the network_config parsing stuff in the same if block.

That makes sense! I also refactored the attach method to make it more concise

ajaykarpur · 2020-09-21T17:16:49Z

tests/unit/sagemaker/monitor/test_model_monitoring.py

+        image_uri=CUSTOM_IMAGE_URI,
+        sagemaker_session=sagemaker_session,
+    )
+    model_monitor_schedule_name = "model-monitoring-without-netwotk-config"


Suggested change

model_monitor_schedule_name = "model-monitoring-without-netwotk-config"

model_monitor_schedule_name = "model-monitoring-without-network-config"

sagemaker-bot · 2020-09-21T17:36:33Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 2d53da5
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-09-21T18:01:00Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 2d53da5
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-09-21T18:08:07Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 2d53da5
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-09-21T18:38:10Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 2d53da5
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

…aker-python-sdk into network-config-keyword

sagemaker-bot · 2020-09-23T00:22:38Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 21c0bcb
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-09-23T00:23:31Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: b0e069b
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-09-23T00:52:30Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 21c0bcb
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-09-23T00:54:37Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: b0e069b
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-09-23T00:54:37Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 21c0bcb
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-09-23T01:00:18Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: b0e069b
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-09-23T02:03:07Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: b0e069b
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-09-24T17:39:21Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: af618c1
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-09-24T18:04:08Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: af618c1
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-09-24T18:17:04Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: af618c1
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-09-24T18:22:50Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: af618c1
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-10-07T17:58:55Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 0b5032c
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-10-07T18:20:57Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 0b5032c
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-10-07T18:21:53Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 0b5032c
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-10-07T18:32:17Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 0b5032c
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

* fix: check optional keyword before accessing * refactor attach method Co-authored-by: Chuyang Deng <[email protected]> Co-authored-by: icywang86rui <[email protected]> Co-authored-by: Ajay Karpur <[email protected]>

fix: check optional keyword before accessing

f3027ca

icywang86rui reviewed Sep 21, 2020

View reviewed changes

Merge branch 'master' into network-config-keyword

2d53da5

ajaykarpur reviewed Sep 21, 2020

View reviewed changes

Chuyang Deng and others added 3 commits September 22, 2020 17:14

refactor attach method

856dde2

Merge branch 'network-config-keyword' of github.com:ChuyangDeng/sagem…

21c0bcb

…aker-python-sdk into network-config-keyword

Merge branch 'master' into network-config-keyword

b0e069b

Merge branch 'master' into network-config-keyword

af618c1

Merge branch 'master' into network-config-keyword

0b5032c

ajaykarpur approved these changes Oct 7, 2020

View reviewed changes

ajaykarpur merged commit 2b812c8 into aws:master Oct 7, 2020

ajaykarpur mentioned this pull request Oct 7, 2020

KeyError: 'NetworkConfig' in predictor.list_monitors() #1910

Closed

	model_monitor_schedule_name = "model-monitoring-without-netwotk-config"
	model_monitor_schedule_name = "model-monitoring-without-network-config"

fix: check optional keyword before accessing #1911

fix: check optional keyword before accessing #1911

Uh oh!

Conversation

chuyang-deng commented Sep 21, 2020

Merge Checklist

General

Tests

Uh oh!

sagemaker-bot commented Sep 21, 2020

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Sep 21, 2020

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Sep 21, 2020

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Sep 21, 2020

AWS CodeBuild CI Report

Uh oh!

icywang86rui commented Sep 21, 2020

Uh oh!

icywang86rui Sep 21, 2020

Choose a reason for hiding this comment

Uh oh!

icywang86rui Sep 21, 2020

Choose a reason for hiding this comment

Uh oh!

chuyang-deng Sep 23, 2020

Choose a reason for hiding this comment

Uh oh!

ajaykarpur Sep 21, 2020

Choose a reason for hiding this comment

Uh oh!

sagemaker-bot commented Sep 21, 2020

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Sep 21, 2020

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Sep 21, 2020

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Sep 21, 2020

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Sep 23, 2020

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Sep 23, 2020

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Sep 23, 2020

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Sep 23, 2020

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Sep 23, 2020

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Sep 23, 2020

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Sep 23, 2020

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Sep 24, 2020

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Sep 24, 2020

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Sep 24, 2020

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Sep 24, 2020

AWS CodeBuild CI Report

Uh oh!