Skip to content

fix: check optional keyword before accessing #1911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Oct 7, 2020
Merged

fix: check optional keyword before accessing #1911

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
f3027ca
fix: check optional keyword before accessing
Sep 21, 2020
2d53da5
Merge branch 'master' into network-config-keyword
icywang86rui Sep 21, 2020
856dde2
refactor attach method
Sep 23, 2020
21c0bcb
Merge branch 'network-config-keyword' of github.com:ChuyangDeng/sagem…
Sep 23, 2020
b0e069b
Merge branch 'master' into network-config-keyword
chuyang-deng Sep 23, 2020
af618c1
Merge branch 'master' into network-config-keyword
chuyang-deng Sep 24, 2020
0b5032c
Merge branch 'master' into network-config-keyword
ajaykarpur Oct 7, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 14 additions & 4 deletions src/sagemaker/model_monitor/model_monitoring.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -672,15 +672,24 @@ def attach(cls, monitor_schedule_name, sagemaker_session=None):
"MonitoringJobDefinition"
]["StoppingCondition"].get("MaxRuntimeInSeconds")

env = schedule_desc["MonitoringScheduleConfig"]["MonitoringJobDefinition"]["Environment"]
env = schedule_desc["MonitoringScheduleConfig"]["MonitoringJobDefinition"].get(
"Environment", None
)

network_config_dict = schedule_desc["MonitoringScheduleConfig"][
"MonitoringJobDefinition"
].get("NetworkConfig")

vpc_config = schedule_desc["MonitoringScheduleConfig"]["MonitoringJobDefinition"][
"NetworkConfig"
].get("VpcConfig")
vpc_config = None
if (
schedule_desc["MonitoringScheduleConfig"]["MonitoringJobDefinition"].get(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be just if network_config_dict is not None

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would also put all the network_config parsing stuff in the same if block.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That makes sense! I also refactored the attach method to make it more concise

"NetworkConfig"
)
is not None
):
vpc_config = schedule_desc["MonitoringScheduleConfig"]["MonitoringJobDefinition"][
"NetworkConfig"
].get("VpcConfig")

security_group_ids = None
if vpc_config is not None:
Expand All @@ -690,6 +699,7 @@ def attach(cls, monitor_schedule_name, sagemaker_session=None):
if vpc_config is not None:
subnets = vpc_config["Subnets"]

network_config = None
if network_config_dict:
network_config = NetworkConfig(
enable_network_isolation=network_config_dict["EnableNetworkIsolation"],
Expand Down
39 changes: 39 additions & 0 deletions tests/unit/sagemaker/monitor/test_model_monitoring.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,31 @@
)
"encrypt_inter_container_traffic=None when creating your NetworkConfig object."

MONITORING_SCHEDULE_DESC = {
"MonitoringScheduleArn": "arn:aws:monitoring-schedule",
"MonitoringScheduleName": "my-monitoring-schedule",
"MonitoringScheduleConfig": {
"MonitoringJobDefinition": {
"MonitoringOutputConfig": {},
"MonitoringResources": {
"ClusterConfig": {
"InstanceCount": 1,
"InstanceType": "ml.t3.medium",
"VolumeSizeInGB": 8,
}
},
"MonitoringAppSpecification": {
"ImageUri": "image-uri",
"ContainerEntrypoint": [
"entrypoint.py",
],
},
"RoleArn": ROLE,
}
},
"EndpointName": "my-endpoint",
}


# TODO-reinvent-2019: Continue to flesh these out.
@pytest.fixture()
Expand All @@ -80,6 +105,9 @@ def sagemaker_session():
name="upload_data", return_value="mocked_s3_uri_from_upload_data"
)
session_mock.download_data = Mock(name="download_data")
session_mock.describe_monitoring_schedule = Mock(
name="describe_monitoring_schedule", return_value=MONITORING_SCHEDULE_DESC
)
return session_mock


Expand Down Expand Up @@ -153,6 +181,17 @@ def test_default_model_monitor_with_invalid_network_config(sagemaker_session):
assert INTER_CONTAINER_ENCRYPTION_EXCEPTION_MSG in str(exception.value)


def test_model_monitor_without_network_config(sagemaker_session):
my_model_monitor = ModelMonitor(
role=ROLE,
image_uri=CUSTOM_IMAGE_URI,
sagemaker_session=sagemaker_session,
)
model_monitor_schedule_name = "model-monitoring-without-netwotk-config"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
model_monitor_schedule_name = "model-monitoring-without-netwotk-config"
model_monitor_schedule_name = "model-monitoring-without-network-config"

attached = my_model_monitor.attach(model_monitor_schedule_name, sagemaker_session)
assert attached.network_config is None


def test_model_monitor_with_invalid_network_config(sagemaker_session):
invalid_network_config = NetworkConfig(encrypt_inter_container_traffic=False)
my_model_monitor = ModelMonitor(
Expand Down