Fix Local Mode s3 training data download. #208
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the S3 training location is passed as s3://my_bucket/training/ (with a trailing slash) Then the objects would have incorrect filenames locally and the container would not find them. This fixes this bug.
Codecov Report
@@ Coverage Diff @@
## master #208 +/- ##
==========================================
+ Coverage 91.46% 91.47% +<.01%
==========================================
Files 45 45
Lines 3165 3166 +1
==========================================
+ Hits 2895 2896 +1
Misses 270 270
Continue to review full report at Codecov.
|
mvsusp
previously approved these changes
May 31, 2018
tests/unit/test_image.py
Outdated
| @@ -366,6 +366,14 @@ def test_download_folder(makedirs): | |||
| calls = [call(os.path.join('/tmp', 'train/train_data.csv')), | |||
| call(os.path.join('/tmp', 'train/validation_data.csv'))] | |||
| obj_mock.download_file.assert_has_calls(calls) | |||
| obj_mock.reset_mock() | |||
|
|
|||
| sagemaker_container._download_folder(BUCKET_NAME, '/prefix/', '/tmp') | |||
There was a problem hiding this comment.
suggestion: either parametrize these 2 test cases or add a comment about the difference between then.
nadiaya
approved these changes
Jun 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the S3 training location is passed as
s3://my_bucket/training/ (with a trailing slash) Then the objects
would have incorrect filenames locally and the container would not find
them. This fixes this bug.
Issue #, if available:
Description of changes:
Merge Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.