Skip to content

feature: upgrade neo mxnet to 1.8 #2235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 25, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 13 additions & 12 deletions src/sagemaker/image_uri_config/neo-mxnet.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,20 +2,21 @@
"processors": ["cpu", "gpu"],
"scope": ["inference"],
"version_aliases": {
"0.12.1": "1.7",
"1.0.0": "1.7",
"1.1.0": "1.7",
"1.2": "1.7",
"1.2.0": "1.7",
"1.2.1": "1.7",
"1.3": "1.7",
"1.3.0": "1.7",
"1.4": "1.7",
"1.4.0": "1.7",
"1.4.1": "1.7"
"0.12.1": "1.8",
"1.0.0": "1.8",
"1.1.0": "1.8",
"1.2": "1.8",
"1.2.0": "1.8",
"1.2.1": "1.8",
"1.3": "1.8",
"1.3.0": "1.8",
"1.4": "1.8",
"1.4.0": "1.8",
"1.4.1": "1.8",
"1.7": "1.8"
},
"versions": {
"1.7": {
"1.8": {
"py_versions": ["py3"],
"registries": {
"af-south-1": "774647643957",
Expand Down
4 changes: 2 additions & 2 deletions tests/data/mxnet_mnist/mnist_neo.py
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ def train(


def model_fn(path_to_model_files):
import neomxnet # noqa: F401
import neomx # noqa: F401

ctx = mx.cpu()
sym, arg_params, aux_params = mx.model.load_checkpoint(
Expand All @@ -120,7 +120,7 @@ def model_fn(path_to_model_files):


def transform_fn(mod, payload, input_content_type, requested_output_content_type):
import neomxnet # noqa: F401
import neomx # noqa: F401

if input_content_type != "application/vnd+python.numpy+binary":
raise RuntimeError("Input content type must be application/vnd+python.numpy+binary")
Expand Down
6 changes: 3 additions & 3 deletions tests/integ/test_neo_mxnet.py
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ def test_attach_deploy(

estimator.compile_model(
target_instance_family=cpu_instance_family,
input_shape={"data": [1, 1, 28, 28], "softmax_label": [1]},
input_shape={"data": [1, 1, 28, 28]},
output_path=estimator.output_path,
)

Expand Down Expand Up @@ -121,7 +121,7 @@ def test_deploy_model(

model.compile(
target_instance_family=cpu_instance_family,
input_shape={"data": [1, 1, 28, 28], "softmax_label": [1]},
input_shape={"data": [1, 1, 28, 28]},
role=role,
job_name=unique_name_from_base("test-deploy-model-compilation-job"),
output_path="/".join(model_data.split("/")[:-1]),
Expand Down Expand Up @@ -163,7 +163,7 @@ def test_inferentia_deploy_model(

model.compile(
target_instance_family=inf_instance_family,
input_shape={"data": [1, 1, 28, 28], "softmax_label": [1]},
input_shape={"data": [1, 1, 28, 28]},
role=role,
job_name=unique_name_from_base("test-deploy-model-compilation-job"),
output_path="/".join(model_data.split("/")[:-1]),
Expand Down