Skip to content

Make record serializer accept one-dimensional arrays #321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 0 commits into from

Conversation

jnclt
Copy link
Contributor

@jnclt jnclt commented Jul 30, 2018

Issue #, if available: #320

Description of changes:
The record serializer processes reshaped arrays.
A unit test for the corresponding one-dimensional case added.

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

  • [x ] I have read the CONTRIBUTING doc
  • [x ] I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have updated the changelog with a description of my changes (if appropriate)
  • I have updated any necessary documentation (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov-io
Copy link

codecov-io commented Jul 30, 2018

Codecov Report

Merging #321 into master will decrease coverage by 0.2%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #321      +/-   ##
==========================================
- Coverage   92.92%   92.71%   -0.21%     
==========================================
  Files          50       50              
  Lines        3475     3475              
==========================================
- Hits         3229     3222       -7     
- Misses        246      253       +7
Impacted Files Coverage Δ
src/sagemaker/amazon/common.py 97.01% <100%> (+0.74%) ⬆️
src/sagemaker/local/image.py 87.09% <0%> (-2.35%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 167ae8e...7d56fe6. Read the comment docs.

Copy link
Contributor

@yangaws yangaws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change LGTM. Just need to add an entry in the changelog.

The current version is 1.8.0. So you could add a dev version 1.8.1dev in changelog, and describe your change there following the style of changes recorded in previous versions.

@jnclt
Copy link
Contributor Author

jnclt commented Aug 3, 2018

@yangaws , since I had made a mess of this pull request (sorry), I created a new one: #334

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants