feat: infer framework and version #3247

rahven14 · 2022-07-17T11:44:28Z

Issue #, if available: #3218

Description of changes:

Automatically infer framework and framework_version in the register step, if the model is a Framework Model. This feature will reduce the number of arguments necessary to register a model in SageMaker Model Registry, making inference recommender more accessible.
Populate framework & framework_version appropriately.
Add register method for XGBoost & Chainer Model Class.
Write tests for the above mentioned changes.

Testing done: units

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

I have read the CONTRIBUTING doc
I certify that the changes I am introducing will be backword compatible, and I have discussed concerns about this, if any, with the Python SDK team
I used the commit message format described in CONTRIBUTING
I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

I have added tests that prove my fix is effective or that my feature works (if appropriate)
I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
I have checked that my tests are not configured for a specific region or account (if appropriate)
I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

…rflow models

…-sdk into feature/infer-framework-and-version

sagemaker-bot · 2022-07-17T11:48:49Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 09b6b05
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-07-17T11:50:26Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 09b6b05
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-07-17T12:33:54Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 09b6b05
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-07-17T12:46:14Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 09b6b05
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

codecov-commenter · 2022-07-17T14:16:56Z

Codecov Report

Merging #3247 (2f2e5cd) into master (b4f05b8) will increase coverage by 0.12%.
The diff coverage is 97.05%.

@@            Coverage Diff             @@
##           master    #3247      +/-   ##
==========================================
+ Coverage   88.79%   88.91%   +0.12%     
==========================================
  Files         203      203              
  Lines       17978    18004      +26     
==========================================
+ Hits        15963    16008      +45     
+ Misses       2015     1996      -19

Impacted Files	Coverage Δ
src/sagemaker/mxnet/model.py	`98.18% <ø> (+1.81%)`	⬆️
src/sagemaker/pytorch/model.py	`96.36% <ø> (+10.90%)`	⬆️
src/sagemaker/sklearn/model.py	`93.87% <ø> (+12.24%)`	⬆️
src/sagemaker/tensorflow/model.py	`96.00% <ø> (+1.00%)`	⬆️
src/sagemaker/workflow/step_collections.py	`93.87% <ø> (ø)`
src/sagemaker/chainer/model.py	`95.91% <87.50%> (-1.65%)`	⬇️
src/sagemaker/huggingface/model.py	`88.73% <100.00%> (+9.62%)`	⬆️
src/sagemaker/model.py	`92.77% <100.00%> (ø)`
src/sagemaker/pipeline.py	`85.13% <100.00%> (ø)`
src/sagemaker/utils.py	`92.85% <100.00%> (+0.16%)`	⬆️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b4f05b8...2f2e5cd. Read the comment docs.

sagemaker-bot · 2022-07-17T14:16:59Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 3e72b56
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-07-17T14:37:42Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 3e72b56
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-07-17T14:52:53Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 3e72b56
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-07-17T16:31:54Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 3e72b56
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-07-17T16:41:36Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 3e72b56
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-07-18T21:52:13Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 3e72b56
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-07-18T21:53:21Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 3e72b56
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-07-25T18:34:01Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 7794457
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-07-25T18:50:55Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 7794457
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-07-25T18:59:05Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 7794457
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-07-25T19:15:25Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 7794457
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-07-25T19:20:20Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 7794457
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-07-26T05:47:10Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 2f2e5cd
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-07-26T05:56:13Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 2f2e5cd
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-07-26T06:08:45Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 2f2e5cd
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-07-26T06:18:15Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 2f2e5cd
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-07-26T06:32:01Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 2f2e5cd
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

ross-claytor-philips · 2022-07-26T14:22:33Z

hi @rahven14 is there any expectation around a timeline for a resolution of this issue?

rahven14 · 2022-07-26T14:25:55Z

hi @rahven14 is there any expectation around a timeline for a resolution of this issue?

Hi @ross-claytor-philips
PR is raised and only merge is pending. I have pinged in the sdk group as well for a merge.
Hopefully by it should be merged within the next 2 days.
Sorry for the delay!

rahven14 added 6 commits July 13, 2022 10:15

infer framework and its version for mxnet, pytorch, sklearn and tenso…

d246c52

…rflow models

feature: infer framework and version for huggingface class

c2cea54

fix: override register method in xgboost & chainer model class

9b39f6a

Merge branch 'master' of https://github.com/rahven14/sagemaker-python…

769c0ae

…-sdk into feature/infer-framework-and-version

Merge branch 'master' of https://github.com/rahven14/sagemaker-python…

08f40e2

…-sdk into feature/infer-framework-and-version

add: auto infer framework and version for inference recommender

09b6b05

fix: remove unwanted 'else' to fix pylint issue

3e72b56

rahven14 and others added 2 commits July 25, 2022 12:46

Merge branch 'aws:master' into feature/infer-framework-and-version

9ef8e42

retrigger checks

7794457

fix: make framework model name as uppercase

2f2e5cd

mufaddal-rohawala requested a review from shreyapandit July 26, 2022 16:40

mufaddal-rohawala approved these changes Jul 27, 2022

View reviewed changes

mufaddal-rohawala changed the title ~~Feature/infer framework and version~~ feat: infer framework and version Jul 27, 2022

mufaddal-rohawala merged commit 920d660 into aws:master Jul 27, 2022

knikure pushed a commit to knikure/sagemaker-python-sdk that referenced this pull request Aug 4, 2022

feat: infer framework and version (aws#3247)

45036e0

knikure mentioned this pull request Oct 6, 2022

fix: CreateModelPackage API error for Scikit-learn and XGBoost frameworkss #3400

Merged

7 tasks

JoseJuan98 pushed a commit to JoseJuan98/sagemaker-python-sdk that referenced this pull request Mar 4, 2023

feat: infer framework and version (aws#3247)

1f54684

feat: infer framework and version #3247

feat: infer framework and version #3247

Uh oh!

Conversation

rahven14 commented Jul 17, 2022

Merge Checklist

General

Tests

Uh oh!

sagemaker-bot commented Jul 17, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jul 17, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jul 17, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jul 17, 2022

AWS CodeBuild CI Report

Uh oh!

codecov-commenter commented Jul 17, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

sagemaker-bot commented Jul 17, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jul 17, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jul 17, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jul 17, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jul 17, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jul 18, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jul 18, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jul 25, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jul 25, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jul 25, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jul 25, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jul 25, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jul 26, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jul 26, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jul 26, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jul 26, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jul 26, 2022

AWS CodeBuild CI Report

Uh oh!

ross-claytor-philips commented Jul 26, 2022

Uh oh!

rahven14 commented Jul 26, 2022

Uh oh!

codecov-commenter commented Jul 17, 2022 •

edited

Loading