change: Add PipelineVariable annotation to framework estimators #3329

qidewenwhen · 2022-08-24T18:42:22Z

Description of changes:

Add PipelineVariable annotation in framework Estimator subclasses. The PipelineVariable annotation will be leveraged by a test mechanism: change: Implement test mechanism for Pipeline variables #3163 to scan and check the incompatible issues between Pipeline steps and downstream classes caused by pipeline variables.
Fix issues figured out by the test mechanism.

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

I have read the CONTRIBUTING doc
I certify that the changes I am introducing will be backword compatible, and I have discussed concerns about this, if any, with the Python SDK team
I used the commit message format described in CONTRIBUTING
I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

I have added tests that prove my fix is effective or that my feature works (if appropriate)
I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
I have checked that my tests are not configured for a specific region or account (if appropriate)
I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

sagemaker-bot · 2022-08-24T19:12:45Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 80bf5fe
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

codecov-commenter · 2022-08-24T19:14:40Z

Codecov Report

Merging #3329 (dbc3ebf) into master (1fa2377) will decrease coverage by 0.04%.
The diff coverage is 93.72%.

@@            Coverage Diff             @@
##           master    #3329      +/-   ##
==========================================
- Coverage   89.17%   89.12%   -0.05%     
==========================================
  Files         204      204              
  Lines       18979    19034      +55     
==========================================
+ Hits        16924    16965      +41     
- Misses       2055     2069      +14

Impacted Files	Coverage Δ
src/sagemaker/workflow/utilities.py	`94.31% <ø> (ø)`
src/sagemaker/session.py	`71.41% <28.57%> (-0.25%)`	⬇️
src/sagemaker/training_compiler/config.py	`80.43% <60.00%> (-2.90%)`	⬇️
src/sagemaker/sklearn/estimator.py	`93.93% <63.63%> (-6.07%)`	⬇️
src/sagemaker/estimator.py	`89.43% <71.42%> (-0.08%)`	⬇️
src/sagemaker/amazon/amazon_estimator.py	`87.82% <81.25%> (-0.62%)`	⬇️
src/sagemaker/amazon/lda.py	`98.03% <92.30%> (+0.16%)`	⬆️
src/sagemaker/algorithm.py	`90.85% <100.00%> (+0.28%)`	⬆️
src/sagemaker/amazon/factorization_machines.py	`100.00% <100.00%> (ø)`
src/sagemaker/amazon/ipinsights.py	`100.00% <100.00%> (ø)`
... and 15 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

sagemaker-bot · 2022-08-24T19:20:28Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 80bf5fe
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-08-24T19:31:19Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 80bf5fe
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-08-24T19:50:30Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 80bf5fe
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-08-24T21:35:38Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 80bf5fe
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-09-21T23:33:17Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: e34ad16
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-09-21T23:58:09Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: e34ad16
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-09-22T00:16:34Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: e34ad16
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-09-22T00:16:55Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: e34ad16
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-09-22T00:38:24Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: e34ad16
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-09-22T01:27:30Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 5a9c5fd
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-09-22T01:35:06Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 5a9c5fd
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-09-22T01:42:57Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 5a9c5fd
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-09-22T02:23:01Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 7dfa685
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-09-22T02:31:36Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 7dfa685
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-09-22T02:38:09Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 7dfa685
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-09-22T02:59:54Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 7dfa685
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-09-22T04:45:42Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 7dfa685
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-09-22T17:19:20Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 7dfa685
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-09-22T22:09:31Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 3bfee1d
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-09-27T01:20:25Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 3bfee1d
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-09-27T01:42:28Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 3bfee1d
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-09-27T01:45:13Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 3bfee1d
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-09-28T23:04:02Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: a7cc1d5
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-09-28T23:28:39Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: a7cc1d5
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-09-28T23:41:42Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: a7cc1d5
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-09-28T23:56:46Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: a7cc1d5
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-09-29T00:03:40Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: a7cc1d5
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-10-03T19:30:26Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: f20ba32
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-10-03T19:33:45Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: f20ba32
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-10-03T19:44:48Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: f20ba32
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-10-03T20:06:44Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: f20ba32
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-10-03T21:51:21Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: f20ba32
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-10-03T22:58:20Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: dbc3ebf
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-10-03T23:18:59Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: dbc3ebf
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-10-03T23:33:40Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: dbc3ebf
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-10-03T23:55:16Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: dbc3ebf
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-10-04T00:09:48Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: dbc3ebf
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-10-04T01:40:26Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: dbc3ebf
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-10-04T03:52:26Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: dbc3ebf
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-10-04T04:22:45Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: dbc3ebf
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

…3329) Co-authored-by: Dewen Qi <[email protected]>

qidewenwhen marked this pull request as draft August 24, 2022 21:38

qidewenwhen force-pushed the est_anno branch from 80bf5fe to e34ad16 Compare September 21, 2022 23:27

qidewenwhen changed the title ~~change: Add PipelineVariable annotation for all estimator subclasses~~ change: Add PipelineVariable annotation to framework estimators Sep 21, 2022

qidewenwhen force-pushed the est_anno branch from e34ad16 to 5a9c5fd Compare September 22, 2022 00:57

qidewenwhen requested a review from jerrypeng7773 September 22, 2022 00:57

qidewenwhen marked this pull request as ready for review September 22, 2022 01:01

qidewenwhen force-pushed the est_anno branch from 5a9c5fd to 7dfa685 Compare September 22, 2022 01:48

mufaddal-rohawala force-pushed the master branch from cb5c991 to d9ab81e Compare September 22, 2022 18:53

qidewenwhen force-pushed the est_anno branch from 7dfa685 to 3bfee1d Compare September 22, 2022 21:39

qidewenwhen force-pushed the est_anno branch from 3bfee1d to a7cc1d5 Compare September 28, 2022 22:57

qidewenwhen force-pushed the est_anno branch from a7cc1d5 to f20ba32 Compare October 3, 2022 18:59

change: Add PipelineVariable annotation to framework estimators

dbc3ebf

qidewenwhen force-pushed the est_anno branch from f20ba32 to dbc3ebf Compare October 3, 2022 22:48

mufaddal-rohawala approved these changes Oct 6, 2022

View reviewed changes

mufaddal-rohawala merged commit d57d891 into aws:master Oct 6, 2022

brockwade633 pushed a commit to brockwade633/sagemaker-python-sdk that referenced this pull request Oct 26, 2022

change: Add PipelineVariable annotation to framework estimators (aws#…

909827b

…3329) Co-authored-by: Dewen Qi <[email protected]>

JoseJuan98 pushed a commit to JoseJuan98/sagemaker-python-sdk that referenced this pull request Mar 4, 2023

change: Add PipelineVariable annotation to framework estimators (aws#…

b48c88f

…3329) Co-authored-by: Dewen Qi <[email protected]>

qidewenwhen deleted the est_anno branch January 25, 2024 18:33

change: Add PipelineVariable annotation to framework estimators #3329

change: Add PipelineVariable annotation to framework estimators #3329

Uh oh!

Conversation

qidewenwhen commented Aug 24, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge Checklist

General

Tests

Uh oh!

sagemaker-bot commented Aug 24, 2022

AWS CodeBuild CI Report

Uh oh!

codecov-commenter commented Aug 24, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

sagemaker-bot commented Aug 24, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Aug 24, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Aug 24, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Aug 24, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Sep 21, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Sep 21, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Sep 22, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Sep 22, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Sep 22, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Sep 22, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Sep 22, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Sep 22, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Sep 22, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Sep 22, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Sep 22, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Sep 22, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Sep 22, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Sep 22, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Sep 22, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Sep 27, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Sep 27, 2022

AWS CodeBuild CI Report

Uh oh!

qidewenwhen commented Aug 24, 2022 •

edited

Loading

codecov-commenter commented Aug 24, 2022 •

edited

Loading