feat: inference instance type conditioned on training instance type #4230

evakravi · 2023-10-25T17:43:47Z

Issue #, if available:

Description of changes:
Allows for JumpStart models to deploy to different hosting instances depending on which instance the training job occurred on.

Testing done:

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

I have read the CONTRIBUTING doc
I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the Python SDK team
I used the commit message format described in CONTRIBUTING
I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

I have added tests that prove my fix is effective or that my feature works (if appropriate)
I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
I have checked that my tests are not configured for a specific region or account (if appropriate)
I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

sagemaker-bot · 2023-10-25T17:52:14Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: cea49d7
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-10-25T18:33:03Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: cea49d7
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-10-25T18:53:34Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: cea49d7
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-10-25T18:55:40Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: cea49d7
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-10-25T19:20:52Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: cea49d7
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

src/sagemaker/instance_types.py

src/sagemaker/jumpstart/artifacts/instance_types.py

src/sagemaker/jumpstart/factory/estimator.py

JGuinegagne · 2023-10-25T19:29:07Z

src/sagemaker/jumpstart/types.py

@@ -581,6 +581,56 @@ def get_instance_specific_environment_variables(self, instance_type: str) -> Dic

        return instance_family_environment_variables

+    def get_instance_specific_default_inference_instance_type(


consider renaming: get_training_instane_specific_default_inference_instance_type (it's a mouthful I know)

JGuinegagne · 2023-10-25T19:30:14Z

src/sagemaker/jumpstart/types.py

+            instance_type, "default_inference_instance_type"
+        )
+
+    def get_instance_specific_supported_inference_instance_types(


same comment please

sagemaker-bot · 2023-10-25T21:32:24Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 389fadf
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-10-25T22:29:43Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 8a696cc
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-10-25T22:49:03Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 8a696cc
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-10-25T23:23:08Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 8a696cc
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

codecov-commenter · 2023-10-25T23:24:18Z

Codecov Report

Attention: 71 lines in your changes are missing coverage. Please review.

Comparison is base (3057f21) 90.27% compared to head (b376a67) 90.32%.
Report is 67 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #4230      +/-   ##
==========================================
+ Coverage   90.27%   90.32%   +0.05%     
==========================================
  Files         993      320     -673     
  Lines       87861    29786   -58075     
==========================================
- Hits        79313    26904   -52409     
+ Misses       8548     2882    -5666

Files	Coverage Δ
src/sagemaker/base_predictor.py	`90.90% <100.00%> (ø)`
src/sagemaker/chainer/estimator.py	`100.00% <ø> (ø)`
src/sagemaker/config/config_schema.py	`100.00% <100.00%> (ø)`
src/sagemaker/djl_inference/model.py	`91.11% <100.00%> (ø)`
src/sagemaker/feature_store/feature_group.py	`78.82% <ø> (ø)`
...emaker/feature_store/feature_processor/__init__.py	`100.00% <100.00%> (ø)`
...eature_store/feature_processor/_config_uploader.py	`97.43% <100.00%> (ø)`
...aker/feature_store/feature_processor/_constants.py	`100.00% <100.00%> (ø)`
...er/feature_store/feature_processor/_data_source.py	`100.00% <100.00%> (ø)`
...agemaker/feature_store/feature_processor/_enums.py	`100.00% <100.00%> (ø)`
... and 62 more

... and 1241 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

sagemaker-bot · 2023-10-25T23:53:41Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 8a696cc
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-10-26T01:26:02Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 8a696cc
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-10-26T13:02:05Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 97a5816
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-10-26T13:08:08Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 97a5816
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-10-26T13:34:04Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 97a5816
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-10-26T14:00:04Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 97a5816
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

…n-training-instance-type

sagemaker-bot · 2023-10-26T17:42:50Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 727989a
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-10-26T18:31:11Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 727989a
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-10-26T18:40:33Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 727989a
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-10-26T18:53:36Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 727989a
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-10-26T20:14:50Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 727989a
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

…n-training-instance-type

sagemaker-bot · 2023-10-26T22:18:46Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: b376a67
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

knikure

/bot run local-mode-tests

sagemaker-bot · 2023-10-26T22:29:31Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: b376a67
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-10-26T22:34:08Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: b376a67
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-10-26T22:35:10Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: b376a67
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-10-26T23:16:19Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: b376a67
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-10-26T23:16:55Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: b376a67
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

feat: inference instance type conditioned on training instance type

cea49d7

evakravi requested a review from a team as a code owner October 25, 2023 17:43

evakravi requested review from akrishna1995 and removed request for a team October 25, 2023 17:43

JGuinegagne reviewed Oct 25, 2023

View reviewed changes

chore: address PR comments

389fadf

Captainia approved these changes Oct 25, 2023

View reviewed changes

chore: remove unnecessary comment

8a696cc

evakravi added 2 commits October 26, 2023 12:08

chore: improve function name to make more generic

c3a0b33

chore: improve logic for getting training instance variants

97a5816

JGuinegagne approved these changes Oct 26, 2023

View reviewed changes

Merge branch 'master' into feat/inference-instance-type-conditioned-o…

727989a

…n-training-instance-type

Merge branch 'master' into feat/inference-instance-type-conditioned-o…

b376a67

…n-training-instance-type

knikure reviewed Oct 26, 2023

View reviewed changes

knikure merged commit 03f901f into aws:master Oct 26, 2023

		@@ -581,6 +581,56 @@ def get_instance_specific_environment_variables(self, instance_type: str) -> Dic

		return instance_family_environment_variables

		def get_instance_specific_default_inference_instance_type(

feat: inference instance type conditioned on training instance type #4230

feat: inference instance type conditioned on training instance type #4230

Uh oh!

Conversation

evakravi commented Oct 25, 2023

Merge Checklist

General

Tests

Uh oh!

sagemaker-bot commented Oct 25, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Oct 25, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Oct 25, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Oct 25, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Oct 25, 2023

AWS CodeBuild CI Report

Uh oh!

Uh oh!

Uh oh!

Uh oh!

JGuinegagne Oct 25, 2023

Choose a reason for hiding this comment

Uh oh!

JGuinegagne Oct 25, 2023

Choose a reason for hiding this comment

Uh oh!

sagemaker-bot commented Oct 25, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Oct 25, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Oct 25, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Oct 25, 2023

AWS CodeBuild CI Report

Uh oh!

codecov-commenter commented Oct 25, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

sagemaker-bot commented Oct 25, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Oct 26, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Oct 26, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Oct 26, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Oct 26, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Oct 26, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Oct 26, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Oct 26, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Oct 26, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Oct 26, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Oct 26, 2023

codecov-commenter commented Oct 25, 2023 •

edited

Loading