Skip to content

fix: Fix Experiment Run integ test w.r.t unexpected boto3 version #4286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 1, 2023
Merged

fix: Fix Experiment Run integ test w.r.t unexpected boto3 version #4286

merged 1 commit into from
Dec 1, 2023

Conversation

qidewenwhen
Copy link
Contributor

@qidewenwhen qidewenwhen commented Nov 30, 2023 •
edited
Loading

Issue #, if available: Some Exp Run failing tests were skipped in this commit ae3748a due to the error thrown `in the training job:

ImportError: cannot import name 'is_s3express_bucket' from 'botocore.utils' (/miniconda3/lib/python3.8/site-packages/botocore/utils.py)

The issue was caused by a breaking change in boto3/botocore 1.33.2, and a github issue was opened under botocore: boto/botocore#3082

Given the suggested solution provided in this github issue, we should make sure all 3 libraries boto3, botocore and s3transfer are in latest version to resolve the issue. However, given the test training job log, the three versions were aligned but the issue persisted.

It turns out that the package version in this image were messed up since the boto3 import happens before the dev SDK package install but the SDK installation upgraded the boto3, botocore and s3transfer versions to the latest. Given that the boto3 import was cached, the upgrade did not take effect and it caused the version conflicts among boto3 vs botocore and s3transfer, which led to this ImportError.

Description of changes: Move all imports (besides the import os, which is required by SDK install) to take place after the SDK installation.

Testing done: Integ tests

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

  • I have read the CONTRIBUTING doc
  • I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the Python SDK team
  • I used the commit message format described in CONTRIBUTING
  • I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
  • I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
  • I have checked that my tests are not configured for a specific region or account (if appropriate)
  • I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@qidewenwhen qidewenwhen requested a review from a team as a code owner November 30, 2023 21:04
@qidewenwhen qidewenwhen requested review from bhupendrasingh and knikure and removed request for a team November 30, 2023 21:04
@mufaddal-rohawala
Copy link
Member

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-notebook-tests
  • Commit ID: e2bbfa9
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@qidewenwhen qidewenwhen requested a review from navaj0 November 30, 2023 21:09
@mufaddal-rohawala
Copy link
Member

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-notebook-tests
  • Commit ID: e2bbfa9
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mufaddal-rohawala
Copy link
Member

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: e2bbfa9
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

qidewenwhen
qidewenwhen commented Nov 30, 2023
View reviewed changes
Copy link
Contributor Author

@qidewenwhen qidewenwhen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/bot run local-mode-tests

@mufaddal-rohawala
Copy link
Member

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: e2bbfa9
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mufaddal-rohawala
Copy link
Member

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: e2bbfa9
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@knikure knikure self-assigned this Nov 30, 2023
@mufaddal-rohawala
Copy link
Member

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: e2bbfa9
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b7337fe) 86.72% compared to head (e2bbfa9) 86.60%.
Report is 3 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #4286      +/-   ##
==========================================
- Coverage   86.72%   86.60%   -0.13%     
==========================================
  Files        1197      380     -817     
  Lines      105630    34815   -70815     
==========================================
- Hits        91609    30150   -61459     
+ Misses      14021     4665    -9356

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mufaddal-rohawala
Copy link
Member

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: e2bbfa9
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

knikure
knikure reviewed Nov 30, 2023
View reviewed changes
Copy link
Contributor

@knikure knikure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/bot run local-mode-tests

@mufaddal-rohawala
Copy link
Member

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: e2bbfa9
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@knikure knikure merged commit 3d07154 into aws:master Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knikure knikure knikure approved these changes

@nmadan nmadan nmadan approved these changes

@navaj0 navaj0 navaj0 approved these changes

@bhupendrasingh bhupendrasingh Awaiting requested review from bhupendrasingh bhupendrasingh is a code owner automatically assigned from aws/sagemaker-ml-frameworks

Assignees

@knikure knikure

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@qidewenwhen @mufaddal-rohawala @codecov-commenter @nmadan @navaj0 @knikure