Skip to content

update changelog #539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 9, 2018
Merged

update changelog #539

merged 3 commits into from
Dec 9, 2018

Conversation

jesterhazy
Copy link
Contributor

Description of changes:

update changelog

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have updated the changelog with a description of my changes (if appropriate)
  • I have updated any necessary documentation (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jesterhazy jesterhazy requested a review from laurenyu December 9, 2018 17:04
@codecov-io
Copy link

codecov-io commented Dec 9, 2018

Codecov Report

Merging #539 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #539      +/-   ##
==========================================
+ Coverage   92.75%   92.77%   +0.01%     
==========================================
  Files          71       71              
  Lines        5357     5357              
==========================================
+ Hits         4969     4970       +1     
+ Misses        388      387       -1
Impacted Files Coverage Δ
src/sagemaker/amazon/common.py 97.01% <0%> (+0.74%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b7cbd4...a02f713. Read the comment docs.

laurenyu
laurenyu previously approved these changes Dec 9, 2018
Copy link
Contributor

@laurenyu laurenyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we add an entry for #500 as well? (sorry for not updating that PR...)

@jesterhazy jesterhazy merged commit 2873e63 into aws:master Dec 9, 2018
@jesterhazy jesterhazy deleted the je-fix-changelog branch December 9, 2018 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants