Skip to content

Remove retry_id in Airflow job name, needs more design on this #568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 21, 2018
Merged

Remove retry_id in Airflow job name, needs more design on this #568

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c493fe6
Remove retry_id in Airflow job name, needs more design on this
yangaws Dec 20, 2018
9b5b661
fix changelog
yangaws Dec 20, 2018
ad09f42
Merge branch 'master' into revert_airflow_retry
yangaws Dec 20, 2018
0eaec56
Merge branch 'master' into revert_airflow_retry
yangaws Dec 20, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion CHANGELOG.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,15 @@
CHANGELOG
=========

1.17.0
======

* bug-fix: Revert appending Airflow retry id to default job name

1.16.3
======

* bug-fix: Local Mode: Allow support for SSH in local mode
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't really remove it - it's already released. Please add a new record for the revert change in the next version.

* bug-fix: Local Mode: Allow support for SSH in local mode
* bug-fix: Append retry id to default Airflow job name to avoid name collisions in retry
* bug-fix: Local Mode: No longer requires s3 permissions to run local entry point file
* feature: Estimators: add support for PyTorch 1.0.0
Expand Down
9 changes: 4 additions & 5 deletions src/sagemaker/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,11 +27,10 @@
import six


AIRFLOW_RETRY_MACRO = "{{ task_instance.try_number }}"
AIRFLOW_TIME_MACRO = "{{ execution_date.strftime('%Y-%m-%d-%H-%M-%S') }}" + "-{}".format(AIRFLOW_RETRY_MACRO)
AIRFLOW_TIME_MACRO_LEN = 22
AIRFLOW_TIME_MACRO_SHORT = "{{ execution_date.strftime('%y%m%d-%H%M') }}" + "-{}".format(AIRFLOW_RETRY_MACRO)
AIRFLOW_TIME_MACRO_SHORT_LEN = 14
AIRFLOW_TIME_MACRO = "{{ execution_date.strftime('%Y-%m-%d-%H-%M-%S') }}"
AIRFLOW_TIME_MACRO_LEN = 19
AIRFLOW_TIME_MACRO_SHORT = "{{ execution_date.strftime('%y%m%d-%H%M') }}"
AIRFLOW_TIME_MACRO_SHORT_LEN = 11


# Use the base name of the image as the job name if the user doesn't give us one
Expand Down
Loading