Enforce 90% Code Coverage for Unit Tests. #97
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #97 +/- ##
=========================================
Coverage ? 89.72%
=========================================
Files ? 34
Lines ? 2015
Branches ? 0
=========================================
Hits ? 1808
Misses ? 207
Partials ? 0Continue to review full report at Codecov.
|
ChoiByungWook
previously approved these changes
Mar 14, 2018
For the integration tests we are not interested in holding the 90% coverage bar. Since we run them in isolation it doesn't report coverage correctly and even setting a low threshold will fail the build. If we set IGNORE_COVERAGE=- then the exit code of coverage result will be ignored.
winstonaws
approved these changes
Mar 16, 2018
apacker
pushed a commit
to apacker/sagemaker-python-sdk
that referenced
this pull request
Nov 15, 2018
Update EnsembleLearnerCensusIncome.ipynb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.