Skip to content

Add CI configuration files #109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 15, 2018
Merged

Add CI configuration files #109

merged 2 commits into from
Nov 15, 2018

Conversation

mvsusp
Copy link
Contributor

@mvsusp mvsusp commented Nov 10, 2018

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

phases:
build:
commands:
- pip install --upgrade pip --quiet
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

quiet hides useful debug info

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I carefully try to keep only useful debug information. I did not consider upgrading pip useful. I am happy to remove if you have any specific considerations.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

without --quiet, pip shows versions of things it is installing, and whether it is reusing a package already installed. useless almost all the time, essential when there are are version conflicts or errors related to unexpected version change.

commands:
- pip install --upgrade pip --quiet
- pip install tox --quiet
- tox -e ${TOX_ENVLIST} -- test/unit
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this project doesn't have a tox config file

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in the branch. ok.

@mvsusp mvsusp merged commit 177773d into script-mode Nov 15, 2018
@mvsusp mvsusp deleted the ci-1541879272 branch November 15, 2018 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants