Skip to content

Add CI configuration files #109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 15, 2018
Merged

Add CI configuration files #109

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b49a6f9
Add CI configuration files
mvsusp Nov 10, 2018
54a0f8d
Delete __init__.py
mvsusp Nov 15, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions buildspec-unit.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
version: 0.2

phases:
build:
commands:
- pip install --upgrade pip --quiet
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

quiet hides useful debug info

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I carefully try to keep only useful debug information. I did not consider upgrading pip useful. I am happy to remove if you have any specific considerations.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

without --quiet, pip shows versions of things it is installing, and whether it is reusing a package already installed. useless almost all the time, essential when there are are version conflicts or errors related to unexpected version change.

- pip install tox --quiet
- tox -e ${TOX_ENVLIST} -- test/unit
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this project doesn't have a tox config file

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tox file is located here https://github.com/aws/sagemaker-tensorflow-container/blob/script-mode/tox.ini

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in the branch. ok.