Skip to content

Version 1.0.0 of the Large payload offloading common library for AWS #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 14, 2020

Conversation

aws-rizi
Copy link
Contributor

@aws-rizi aws-rizi commented Jul 9, 2020

Version 1.0.0 of the Large payload offloading common library for AWS

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@robin-aws robin-aws self-requested a review July 9, 2020 16:50
@aws-rizi aws-rizi requested a review from adam-aws July 9, 2020 16:51
@aws-rizi aws-rizi force-pushed the aws-rizi/dev branch 2 times, most recently from 8ba8178 to 9100a2c Compare July 9, 2020 18:49
@adam-aws adam-aws self-requested a review July 9, 2020 19:41
adam-aws
adam-aws previously approved these changes Jul 9, 2020
Copy link
Contributor

@adam-aws adam-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@robin-aws robin-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm definitely liking this as a very general-purpose library! There are just a few lingering references to SQS/SNS that are worth cleaning up.

@aws-rizi aws-rizi force-pushed the aws-rizi/dev branch 2 times, most recently from 2c1e4f3 to 83c6844 Compare July 13, 2020 16:43
@aws-rizi aws-rizi requested review from robin-aws and adam-aws July 13, 2020 16:51
adam-aws
adam-aws previously approved these changes Jul 13, 2020
Copy link

@robin-aws robin-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@aws-rizi aws-rizi merged commit 473db78 into master Jul 14, 2020
@aws-rizi aws-rizi deleted the aws-rizi/dev branch July 14, 2020 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants