-
Notifications
You must be signed in to change notification settings - Fork 15
Version 1.0.0 of the Large payload offloading common library for AWS #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
8ba8178
to
9100a2c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm definitely liking this as a very general-purpose library! There are just a few lingering references to SQS/SNS that are worth cleaning up.
src/main/java/com/amazonaws/largepayloadoffloading/ExtendedClientConstants.java
Outdated
Show resolved
Hide resolved
src/main/java/com/amazonaws/largepayloadoffloading/CountingOutputStream.java
Outdated
Show resolved
Hide resolved
src/main/java/com/amazonaws/largepayloadoffloading/ExtendedClientConfiguration.java
Outdated
Show resolved
Hide resolved
src/main/java/com/amazonaws/largepayloadoffloading/ExtendedClientConstants.java
Outdated
Show resolved
Hide resolved
src/main/java/com/amazonaws/largepayloadoffloading/LargePayloadStore.java
Outdated
Show resolved
Hide resolved
src/main/java/com/amazonaws/largepayloadoffloading/PayloadS3Pointer.java
Outdated
Show resolved
Hide resolved
2c1e4f3
to
83c6844
Compare
src/main/java/com/amazonaws/largepayloadoffloading/Constants.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Version 1.0.0 of the Large payload offloading common library for AWS
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.