Better error message for mistaken import #40
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
reviewing |
mheiber
suggested changes
Oct 1, 2019
| @@ -2297,7 +2308,17 @@ namespace ts { | |||
| } | |||
| } | |||
| else { | |||
| error(name, Diagnostics.Module_0_has_no_exported_member_1, moduleName, declarationName); | |||
| if (moduleSymbol.exports && moduleSymbol.exports.has("default" as __String)) { | |||
There was a problem hiding this comment.
Judging by other code in the checker, I think this could be more idiomatic.
- can you try
.has(InternalSymbolName.Default)instead of a hard-coded string? Then it's more consistent with the surrounding code and we don't need a cast.
| @@ -1,4 +1,4 @@ | |||
| tests/cases/compiler/service.ts(1,8): error TS1192: Module '"tests/cases/compiler/db"' has no default export. | |||
| tests/cases/compiler/service.ts(1,8): error TS6222: Module '"tests/cases/compiler/db"' has no default export. Did you mean to use 'import {db} from "tests/cases/compiler/db"' instead? | |||
There was a problem hiding this comment.
I think it's more idiomatic to see a space around the identifier in the curlies: import { db } from ....
Basing this on the formatting for destructuring assignment in the TS codebase, as well as how prettier formats imports, to the best of my knowledge.
Signed-off-by: Mukesh Prasad <[email protected]>
|
@mheiber addressed your review comments. |
mheiber
pushed a commit
that referenced
this pull request
Oct 1, 2019
Issue number of the reported bug or feature request: microsoft#13601
|
it's live! microsoft#33706 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number of the reported bug or feature request: microsoft#13601