Skip to content

Better error message for mistaken import #33706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 1, 2019
Merged

Better error message for mistaken import #33706

merged 1 commit into from
Oct 1, 2019

Conversation

mheiber
Copy link
Contributor

@mheiber mheiber commented Oct 1, 2019 •
edited
Loading

Issue number of the reported bug or feature request: #13601

work by @prime-optimus

Please verify that:

  • There is an associated issue in the Backlog milestone (required)
  • Code is up-to-date with the master branch
  • You've successfully run gulp runtests locally
  • There are new or updated unit tests validating the change

Fixes #13601

@prime-optimus @mheiber
Better error message for mistaken import (#40)
03a3589 
Issue number of the reported bug or feature request: microsoft#13601
@mheiber mheiber mentioned this pull request Oct 1, 2019
Merged
@DanielRosenwasser DanielRosenwasser merged commit a04f1eb into microsoft:master Oct 1, 2019
This was referenced Oct 1, 2019
Merged
Merged
@mheiber mheiber deleted the 13624 branch October 1, 2019 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanielRosenwasser DanielRosenwasser DanielRosenwasser approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Better error message when users mistakenly import from named vs. default export
3 participants
@mheiber @DanielRosenwasser @prime-optimus