Skip to content

Move error codes to appropriate section #33709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 1, 2019
Merged

Move error codes to appropriate section #33709

merged 2 commits into from
Oct 1, 2019

Conversation

DanielRosenwasser
Copy link
Member

@DanielRosenwasser DanielRosenwasser merged commit 20f42f4 into master Oct 1, 2019
@DanielRosenwasser DanielRosenwasser deleted the moveMessageNumbers branch October 1, 2019 19:37
@mheiber
Copy link
Contributor

mheiber commented Oct 2, 2019 •
edited
Loading

Hey, sorry about that! Thanks for fixing.
I tried to group the errors about default exports in the same section and saw that Module '{0} has no default export. has code 1192.

So I can put things in the right section next time, how do we pick sections?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sheetalkamat sheetalkamat sheetalkamat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DanielRosenwasser @mheiber @sheetalkamat