Add possibility to use custom `User Data` #20

SweetOps · 2017-11-24T12:52:45Z

What

Add possibility to use custom User Data
Update README
Add template for PR

Why

Some AMIs doesn't support classic User Data

SweetOps · 2017-11-24T12:56:46Z

has been tested with following manifest

data "aws_ami" "pfsense" {
  most_recent = "true"

  filter {
    name   = "description"
    values = ["Netgate pfSense Certified 2.3.4"]
  }
}

data "template_file" "init" {
  template = "${file("1.sh")}"
}

module "admin_tier" {
  source                        = "cloudposse/terraform-aws-ec2-instance"
  ssh_key_pair                  = "sweetops"
  ami                           = "${data.aws_ami.pfsense.image_id}"
  vpc_id                        = "vpc-someid"
  subnet                        = "subnet-someid"
  associate_public_ip_address   = "true"
  create_default_security_group = "false"
  name                          = "pf"
  namespace                     = "cp"
  stage                         = "dev"
  user_data                     = ["${data.template_file.init.rendered}"]
}

module "admin_tier1" {
  source                        = "cloudposse/terraform-aws-ec2-instance"
  ssh_key_pair                  = "sweetops"
  ami                           = "${data.aws_ami.pfsense.image_id}"
  vpc_id                        = "vpc-someid"
  subnet                        = "subnet-someid"
  associate_public_ip_address   = "true"
  create_default_security_group = "false"
  name                          = "pf1"
  namespace                     = "cp"
  stage                         = "dev"
  custom_user_data              = ["${data.template_file.init.rendered}"]
}

const-bon · 2017-11-24T14:40:37Z

README.md

@@ -56,7 +56,7 @@ module "kafka_instance" {
 This module depends on these modules:

 * [terraform-null-label](https://github.com/cloudposse/terraform-null-label)
-* [terraform-template-user-data-github-authorized-keys](https://github.com/cloudposse/terraform-template-user-data-github-authorized-keys)
+* [terraform-template-User Data-github-authorized-keys](https://github.com/cloudposse/terraform-template-user-data-github-authorized-keys)


Rename to terraform-template-user-data-github-authorized-keys.

const-bon · 2017-11-24T15:20:01Z

README.md

+| `statistic_level`               |                   `Maximum`                    | Statistic to apply to the alarm's associated metric                                                                          |    No    |
+| `metric_threshold`              |                      `1`                       | Value against which the specified statistic is compared                                                                      |    No    |
+| `default_alarm_action`          | `action/actions/AWS_EC2.InstanceId.Reboot/1.0` | String of action to execute when this alarm transitions into an ALARM state                                                  |    No    |
+| `user_data`                     |                      `[]`                      | `User Data` which be concated with `terraform-template-User Data-github-authorized-keys`. Conflicts with  `custom_user_data` |    No    |


terraform-template-user-data-github-authorized-keys

const-bon · 2017-11-24T15:21:45Z

variables.tf

 }

 variable "user_data" {
-  description = "User data to provide when launching the instance"
+  description = "User Data which be concated with `terraform-template-User Data-github-authorized-keys`"


terraform-template-user-data-github-authorized-keys

const-bon · 2017-11-24T16:14:50Z

main.tf

@@ -7,6 +7,7 @@ locals {
  availability_zone    = "${var.availability_zone != "" ? var.availability_zone : data.aws_subnet.default.availability_zone}"
  ami                  = "${var.ami != "" ? var.ami : data.aws_ami.default.image_id}"
  root_volume_type     = "${var.root_volume_type != "" ? var.root_volume_type : data.aws_ami.info.root_device_type}"
+  user_data            = "${length(var.custom_user_data) > 0 ? join("", var.custom_user_data) : join("", data.template_file.user_data.*.rendered)}"


Should we use var.custom_user_data instead of join("", var.custom_user_data) ?

in this case will be error during plan\apply, because trueval\falseeval should be string

const-bon · 2017-11-24T16:19:06Z

user_data.tf

@@ -1,4 +1,5 @@
 data "template_file" "user_data" {
+  count    = "${local.instance_count && length(var.custom_user_data) == 0 ? 1 : 0}"


We should use local.instance_count == 0.

const-bon · 2017-11-24T16:19:27Z

outputs.tf

  value       = "${zipmap(aws_network_interface.additional.*.id, aws_eip.additional.*.public_ip)}"
 }

+output "additional_eni_private" {


Why do we need this for?

for example it need in sth for template rendering

SweetOps · 2017-11-27T18:41:03Z

osterman · 2017-12-08T19:58:37Z

We are overloading this module. Enforcing a convention on the user data that including using github_authorized_keys is too restrictive. It's easy enough to pass these when invoking the module, especially since we have a module to generate user data for ghk.

Closing this in favor of #22

SweetOps added 5 commits November 24, 2017 13:28

init

68d19d3

Merge branch 'master' into custom_user_data

8cd4ca1

init

5ad9547

pr template

97c1625

fix typo

bf2884c

SweetOps self-assigned this Nov 24, 2017

SweetOps requested review from osterman and const-bon November 24, 2017 12:52

const-bon reviewed Nov 24, 2017

View reviewed changes

SweetOps added 5 commits November 24, 2017 18:34

fix typos

1b6cb29

typo #3

29178b3

change to string

ea09e0a

fix

f451b5e

hotfix

f4c6650

osterman closed this Dec 8, 2017

aknysh deleted the custom_user_data branch June 3, 2018 23:09

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Add possibility to use custom `User Data` #20

Add possibility to use custom `User Data` #20

Uh oh!

SweetOps commented Nov 24, 2017

Uh oh!

SweetOps commented Nov 24, 2017

Uh oh!

const-bon Nov 24, 2017

Uh oh!

const-bon Nov 24, 2017

Uh oh!

const-bon Nov 24, 2017

Uh oh!

const-bon Nov 24, 2017

Uh oh!

SweetOps Nov 24, 2017

Uh oh!

const-bon Nov 24, 2017

Uh oh!

const-bon Nov 24, 2017

Uh oh!

SweetOps Nov 24, 2017

Uh oh!

SweetOps commented Nov 27, 2017

Uh oh!

osterman commented Dec 8, 2017

Uh oh!

Uh oh!

		@@ -1,4 +1,5 @@
		data "template_file" "user_data" {
		count = "${local.instance_count && length(var.custom_user_data) == 0 ? 1 : 0}"

Uh oh!

Add possibility to use custom User Data #20

Add possibility to use custom User Data #20

Uh oh!

Conversation

SweetOps commented Nov 24, 2017

What

Why

Uh oh!

SweetOps commented Nov 24, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

SweetOps commented Nov 27, 2017

Uh oh!

osterman commented Dec 8, 2017

Uh oh!

Uh oh!

Add possibility to use custom `User Data` #20

Add possibility to use custom `User Data` #20