Skip to content

Remove generated user data from module (breaking change) #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 8, 2017
Merged

Remove generated user data from module (breaking change) #22

merged 3 commits into from
Dec 8, 2017

Conversation

osterman
Copy link
Member

@osterman osterman commented Dec 8, 2017

what

  • Remove generated user data from module

why

  • Too opinionated
  • User data not compatible with a wide array of images
  • Assumed bash
  • Required github authorized keys, even if it wasn't supported by image
  • User data should be passed in by caller

upgrading

  • To upgrade to this module, pass in required script to user_data variable

@osterman osterman mentioned this pull request Dec 8, 2017
Closed
const-bon
const-bon previously approved these changes Dec 8, 2017
View reviewed changes
@osterman osterman merged commit 6a4eb64 into master Dec 8, 2017
@aknysh aknysh deleted the deprecate-auto-user-data branch June 3, 2018 23:09
@jedineeper jedineeper mentioned this pull request Oct 3, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@const-bon const-bon const-bon approved these changes

@goruha goruha Awaiting requested review from goruha

@s2504s s2504s Awaiting requested review from s2504s

@drama17 drama17 Awaiting requested review from drama17

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@osterman @const-bon