chore: Update publish docs #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erezrokah
commented
Jan 26, 2024
| @@ -0,0 +1,3 @@ | |||
| # JavaScript Source Plugin Template | |||
There was a problem hiding this comment.
At least once doc file is needed for publishing to work
erezrokah
commented
Jan 26, 2024
| @@ -27,7 +27,6 @@ | |||
| "scripts": { | |||
| "dev": "ts-node --esm src/main.ts serve", | |||
| "build": "rm -rf dist && tsc", | |||
| "package:container": "docker build -t cq-js-sample:latest .", | |||
There was a problem hiding this comment.
This was outdated, the JS SDK will run docker build instead
erezrokah
commented
Jan 26, 2024
| @@ -85,12 +85,12 @@ export const newSamplePlugin = () => { | |||
| spec, | |||
| { noConnection }, | |||
| ) => { | |||
| pluginClient.spec = parseSpec(spec); | |||
There was a problem hiding this comment.
the package command and some others pass an empty spec and noConnection: true so we should skip parsing the spec and initializing the client for noConnection: true
pilvikala
approved these changes
Jan 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to cloudquery/python-plugin-template#5 updates the template to better explain how to publish the docker image to the CloudQuery registry