-
Notifications
You must be signed in to change notification settings - Fork 0
chore: Update publish docs #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
# JavaScript Source Plugin Template | ||
|
||
This is the plugin documentation that will get published to Hub. Read more about publishing at [CloudQuery Docs](https://docs.cloudquery.io/docs/developers/publishing-a-plugin-to-the-hub) |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -27,7 +27,6 @@ | |
"scripts": { | ||
"dev": "ts-node --esm src/main.ts serve", | ||
"build": "rm -rf dist && tsc", | ||
"package:container": "docker build -t cq-js-sample:latest .", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This was outdated, the JS SDK will run docker build instead |
||
"format": "prettier --write 'src/**/*.ts'", | ||
"format:check": "prettier --check 'src/**/*.ts'", | ||
"lint": "eslint --max-warnings 0 --ext .ts src", | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -85,12 +85,12 @@ export const newSamplePlugin = () => { | |
spec, | ||
{ noConnection }, | ||
) => { | ||
pluginClient.spec = parseSpec(spec); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. the |
||
pluginClient.client = { id: () => "cq-js-sample" }; | ||
if (noConnection) { | ||
pluginClient.allTables = []; | ||
return pluginClient; | ||
} | ||
pluginClient.spec = parseSpec(spec); | ||
pluginClient.client = { id: () => "cq-js-sample" }; | ||
pluginClient.allTables = await getTables(); | ||
|
||
return pluginClient; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At least once doc file is needed for publishing to work